1718192 - Land various cleanup related to bfcache navigation support

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

Bug 1713607 starts to grow with a long list of patches made of preliminary cleanup which can be landed beforehand.
This include test fixes, new tests, and various tweaks that are obvious and can be landed right away. For the last patches of this queue, test coverage will only be possible once bfcache navigation actually work and will be covered by bug 1713607.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1718192 - [devtools] Fix bfcache TargetCommand test against bfcache navigations.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1718192 - [devtools] Cover target destruction events when doing bfcache navigations.

The test was already passing.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1718192 - [devtools] All server side targets follow the WindowGlobal lifecycle.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1718192 - [devtools] Implements ProcessDescriptor.isParentProcessDescriptor.

This is a shortcut to avoid having to do descriptorFront.isProcessDescriptor && descriptorFront.isParent.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1718192 - [devtools] Fix various edgecase when doing BFCache navigation.

• avoid unwatching DOCUMENT_EVENT in case of target-switching
• ensure emitting DevToolsFrameChild:destroy for all currently registered target actors
  (didDestroy was clearing the list of actors used by _getTargetActorForWatcherActorID)
• do not try to stop and restart server side watchers in case of bfcache navigation

Comment 6

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6437f6267288de158e331fa31fbd86c762ecda8

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dbffbcf6c06
[devtools] Fix bfcache TargetCommand test against bfcache navigations. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6d0c614aa68b
[devtools] Cover target destruction events when doing bfcache navigations. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/727f24670ede
[devtools] All server side targets follow the WindowGlobal lifecycle. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/e545e71c6b6f
[devtools] Implements ProcessDescriptor.isParentProcessDescriptor. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/312cc80160cb
[devtools] Fix various edgecase when doing BFCache navigation. r=nchevobbe

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5dbffbcf6c06
https://hg.mozilla.org/mozilla-central/rev/6d0c614aa68b
https://hg.mozilla.org/mozilla-central/rev/727f24670ede
https://hg.mozilla.org/mozilla-central/rev/e545e71c6b6f
https://hg.mozilla.org/mozilla-central/rev/312cc80160cb