1713607 - Clear the console in case of bfcache navigations

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Bug 1702511 won't be enough to fix console clearance on bfcache navigation.
We end up missing DOCUMENT_EVENT will-navigate in case of bfcache navigation.
It looks like the target actor is destroyed too close to the emissing of this resource and is the lost on its way to reach the frontend.
We need some more tweak on top of 1702511, dedicated to bfcache to fix this.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1713607 - [devtools] Emit DOCUMENT_EVENT will-navigate in case of bfcache navigations.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1713607 - [devtools] Fix bfcache TargetCommand test against bfcache navigations

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1713607 - [devtools] Cover target destruction events when doing bfcache navigations.

The test was already passing.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1713607 - [devtools] All server side targets follow the WindowGlobal lifecycle.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1713607 - [devtools] Cover console clearance when doing BFCache navigations.

Comment 6

[Phabricator Automation]

Comment on attachment 9228377 [details]
Bug 1713607 - [devtools] Fix bfcache TargetCommand test against bfcache navigations

Revision D118502 was moved to bug 1718192. Setting attachment 9228377 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9228378 [details]
Bug 1713607 - [devtools] Cover target destruction events when doing bfcache navigations.

Revision D118503 was moved to bug 1718192. Setting attachment 9228378 [details] to obsolete.

Comment 8

[Phabricator Automation]

Comment on attachment 9228379 [details]
Bug 1713607 - [devtools] All server side targets follow the WindowGlobal lifecycle.

Revision D118504 was moved to bug 1718192. Setting attachment 9228379 [details] to obsolete.

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1713607 - [devtools] Emit the will-navigate from the client side.

Comment 10

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1713607 - [devtools] Cover bfcache navigation in DOCUMENT_EVENT test.

Comment 11

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1713607 - Implement WebProgress.browsingContext

This helps knowing which particular BrowsingContext is navigating.

Comment 12

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1713607 - Fix WebProgress STATE_START+DOCUMENT+WINDOW for bfcache navigations.

Ensure firing the onStateChange on the BrowsingContext's WebProgress
of the page we navigate from instead of the one we navigate to.
(which was what used to happen before fission/bfcacheInParent)

Comment 13

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1713607 - [devtools] Make WatcherFront.getBrowsingContextTarget synchronous for client side-top target.

This helps ResourceCommand immediately throttle parent process resources.
Without this, when we don't have server side target switching enabled,
and still create the top level target via the TabDescriptor, we are still
asynchronous and this can be confusing from ResourceCommand.onResourceAvailable.

May be we could have two versions of this function?
One synchronous for ResourceCommand and another, more powerful but async
for inspector codebase (which should also work for BC ids of same-process iframes).

Comment 14

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1713607 - [devtools] Fix duplicated target-destroyed for bfcache navigations.

Fix client side target destruction for bfcache navigations.

Comment 15

[Phabricator Automation]

Comment on attachment 9230752 [details]
Bug 1713607 - Implement WebProgress.browsingContext

Revision D119647 was moved to bug 1720304. Setting attachment 9230752 [details] to obsolete.

Comment 16

[Phabricator Automation]

Comment on attachment 9230754 [details]
Bug 1713607 - [devtools] Make WatcherFront.getBrowsingContextTarget synchronous for client side-top target.

Revision D119649 was moved to bug 1720732. Setting attachment 9230754 [details] to obsolete.

Comment 17

[Phabricator Automation]

Comment on attachment 9230753 [details]
Bug 1713607 - Fix WebProgress STATE_START+DOCUMENT+WINDOW for bfcache navigations.

Revision D119648 was moved to bug 1721203. Setting attachment 9230753 [details] to obsolete.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ca0f57d9879
[devtools] Cover console clearance when doing BFCache navigations. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/cd6e4017fab7
[devtools] Cover bfcache navigation in DOCUMENT_EVENT test. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/ae4b92b55d08
[devtools] Emit DOCUMENT_EVENT will-navigate in case of bfcache navigations. r=nchevobbe,jdescottes

Comment 19

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1ca0f57d9879
https://hg.mozilla.org/mozilla-central/rev/cd6e4017fab7
https://hg.mozilla.org/mozilla-central/rev/ae4b92b55d08