Closed Bug 1713607 Opened 2 years ago Closed 1 year ago

Clear the console in case of bfcache navigations

Categories

(DevTools :: Console, enhancement)

enhancement

Tracking

(Fission Milestone:MVP, firefox92 fixed)

RESOLVED FIXED
92 Branch
Fission Milestone MVP
Tracking Status
firefox92 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(3 files, 8 obsolete files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

Bug 1702511 won't be enough to fix console clearance on bfcache navigation.
We end up missing DOCUMENT_EVENT will-navigate in case of bfcache navigation.
It looks like the target actor is destroyed too close to the emissing of this resource and is the lost on its way to reach the frontend.
We need some more tweak on top of 1702511, dedicated to bfcache to fix this.

Summary: Clear the console is case of bfcache navigations → Clear the console in case of bfcache navigations
Whiteboard: dt-fission-m3-triage
Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp
Fission Milestone: --- → MVP
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Fission Milestone: MVP → M8
Blocks: 1717611
Attachment #9224293 - Attachment description: Bug 1713607 - [devtools] ensure emitting DOCUMENT_EVENT will-navigate in case of bfcache navigations. → Bug 1713607 - [devtools] Emit DOCUMENT_EVENT will-navigate in case of bfcache navigations.
Depends on: 1718192

Comment on attachment 9228377 [details]
Bug 1713607 - [devtools] Fix bfcache TargetCommand test against bfcache navigations

Revision D118502 was moved to bug 1718192. Setting attachment 9228377 [details] to obsolete.

Attachment #9228377 - Attachment is obsolete: true

Comment on attachment 9228378 [details]
Bug 1713607 - [devtools] Cover target destruction events when doing bfcache navigations.

Revision D118503 was moved to bug 1718192. Setting attachment 9228378 [details] to obsolete.

Attachment #9228378 - Attachment is obsolete: true

Comment on attachment 9228379 [details]
Bug 1713607 - [devtools] All server side targets follow the WindowGlobal lifecycle.

Revision D118504 was moved to bug 1718192. Setting attachment 9228379 [details] to obsolete.

Attachment #9228379 - Attachment is obsolete: true
Fission Milestone: M8 → MVP

This helps knowing which particular BrowsingContext is navigating.

Ensure firing the onStateChange on the BrowsingContext's WebProgress
of the page we navigate from instead of the one we navigate to.
(which was what used to happen before fission/bfcacheInParent)

This helps ResourceCommand immediately throttle parent process resources.
Without this, when we don't have server side target switching enabled,
and still create the top level target via the TabDescriptor, we are still
asynchronous and this can be confusing from ResourceCommand.onResourceAvailable.

May be we could have two versions of this function?
One synchronous for ResourceCommand and another, more powerful but async
for inspector codebase (which should also work for BC ids of same-process iframes).

Fix client side target destruction for bfcache navigations.

Depends on: 1720304

Comment on attachment 9230752 [details]
Bug 1713607 - Implement WebProgress.browsingContext

Revision D119647 was moved to bug 1720304. Setting attachment 9230752 [details] to obsolete.

Attachment #9230752 - Attachment is obsolete: true

Comment on attachment 9230754 [details]
Bug 1713607 - [devtools] Make WatcherFront.getBrowsingContextTarget synchronous for client side-top target.

Revision D119649 was moved to bug 1720732. Setting attachment 9230754 [details] to obsolete.

Attachment #9230754 - Attachment is obsolete: true
Attachment #9228903 - Attachment is obsolete: true
Depends on: 1721203

Comment on attachment 9230753 [details]
Bug 1713607 - Fix WebProgress STATE_START+DOCUMENT+WINDOW for bfcache navigations.

Revision D119648 was moved to bug 1721203. Setting attachment 9230753 [details] to obsolete.

Attachment #9230753 - Attachment is obsolete: true
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ca0f57d9879
[devtools] Cover console clearance when doing BFCache navigations. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/cd6e4017fab7
[devtools] Cover bfcache navigation in DOCUMENT_EVENT test. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/ae4b92b55d08
[devtools] Emit DOCUMENT_EVENT will-navigate in case of bfcache navigations. r=nchevobbe,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Blocks: 1722305
Attachment #9230755 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.