1718228 - Fix IDL for CollectedClientData

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, task, P2)

Description

[Daniel Veditz [:dveditz]]

In our Implementation CollectedClientData has an optional DOMString member tokenBindingId. This is the wrong name and type. Instead it should look like

dictionary CollectedClientData {
    ...
    TokenBinding                 tokenBinding;
};

dictionary TokenBinding {
    required DOMString status;
    DOMString id;
};

enum TokenBindingStatus { "present", "supported" };

So far it hasn't caused a problem since we don't support it, and as an optional member no one has noticed that it would have been named wrong and have the wrong type.

We also have to get rid of three members that don't exist anymore:

    required DOMString           hashAlgorithm;
    AuthenticationExtensionsClientInputs clientExtensions = {};
    AuthenticationExtensionsAuthenticatorInputs authenticatorExtensions;

Comment 1

[R. Martinho Fernandes [:rmf]]

Attachment: Bug 1718228 - Make CollectedClientData follow the spec r?dveditz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d45b16f97f9f
Make CollectedClientData follow the spec r=dveditz,baku

Comment 3

[Atila Butkovits]

Backed out for causing failures at test_webauthn_loopback.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/70709554ec67746ac4adffb3155169b162aaa479

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=acPvgZv4TmOUXBpiZfvL3g.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d45b16f97f9f0cb6714729a3efe74620b8986ec8

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=375992988&repo=autoland&lineNumber=4030
https://treeherder.mozilla.org/logviewer?job_id=375992912&repo=autoland&lineNumber=3246

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2908f3e5373
Make CollectedClientData follow the spec r=dveditz,baku

Comment 5

[Cristian Tuns]

Backed out for causing mochitest failure in test_webauthn_loopback.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/webauthn/tests/test_webauthn_loopback.html | Hash algorithm is correct - got undefined, expected "SHA-256"

Comment 6

[Iulian Moraru]

This also perma fails on this: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=NzBAzmfkRw6gIVakQxn1Tw.0&fromchange=87cf7f130a02cb1f22fdca353ddfc3bf8be5da70&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Ctsan%2Copt%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-tsan-qr%2Fopt-mochitest-browser-chrome-swr-fis-e10s%2Cbc2&tochange=e2908f3e5373d6b0e544d5277da9775f9138651d

Failure log for fails on browser_fido_appid_extension.js

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6807a13afdd9
Make CollectedClientData follow the spec r=dveditz,baku

Comment 8

[Norisz Fay [:noriszfay]]

Backed out for causing browser-chrome failures on browser_fido_appid_extension.js

Backout link

Push with failures

Failure log

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:rmf, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7b85c679074
Make CollectedClientData follow the spec r=dveditz,baku

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f7b85c679074