1718436 - Middle-Clicking any line under "History - Recently Closed Tabs" reopens 2 tabs, instead of 1.

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[sata6767]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Have 25 lines under History -> Recently Closed Tabs (The maximum amount)

Middle mouse click (meaning using the mouse wheel) any line under History -> Recently Closed Tabs

Actual results:

Two tabs reopen. The line/tab I middle clicked on, as well as another one, which is the line/tab just under the line I clicked on.

The 2 opened tabs may appear in different locations in the

Expected results:

Only the tab I middle clicked on should have reopened (the same thing as if I would have left clicked it)

I did not find any information regarding this, so I assume that this is indeed a bug, and not intended behavior.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Session Restore' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=81767b813eb8f9c0148ef45ea7222515e91a79e1&tochange=fd72fcc0fa52d52635fa4a5690b2c416cdd43d3f

Comment 3

[u608768]

Attachment: Bug 1718436 - Don't register the "Recently Closed Tabs" middle click handler for menuitems, r?Gijs

Causes us to handle middle clicks twice, which results in us opening two recent
tabs instead of one. The regressing bug dealt with similar problems in D112046.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2092d6ef5f95
Don't register the "Recently Closed Tabs" middle click handler for menuitems, r=Gijs

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2092d6ef5f95

Comment 6

[:Gijs (out for now; he/him)]

Am I right in thinking we should probably uplift this so it's fixed in 91? :-)

Comment 7

[u608768]

Comment on attachment 9230525 [details]
Bug 1718436 - Don't register the "Recently Closed Tabs" middle click handler for menuitems, r?Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Middle clicking "recently closed tab" entries will continue to open two tabs instead of one.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small code change covered by tests.
• String changes made/needed:

Comment 8

[u608768]

(In reply to :Gijs (he/him) from comment #6)

Am I right in thinking we should probably uplift this so it's fixed in 91? :-)

Yes, done!

Though unsure if I need to request approval for esr91 separately from beta.

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9230525 [details]
Bug 1718436 - Don't register the "Recently Closed Tabs" middle click handler for menuitems, r?Gijs

Approved for 91 beta 5, thanks!

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/09faa442838e

Comment 11

[:Gijs (out for now; he/him)]

(In reply to :kashav from comment #8)

Though unsure if I need to request approval for esr91 separately from beta.

From matrix:

jld: If a patch gets uplifted to Beta 91, is it also auto-uplifted to ESR 91, or not? (I used to know this kind of thing, but it's been a while.)

jcristau: @jld yes
we'll keep beta and esr91 in sync until close to release

So you should be all done here.

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue using Firefox 91.0a1 (20210627213728) on Windows 10x64 by middle-clicking under any closed tab inside Menu Bar -> History-> Recently Closed Tabs.
Verified fixed with Firefox 91.0b6 (20210722185635) and 92.0a1 (20210722214815) on Windows 10x64, macOS 10.15 and Ubuntu 18.04.