1718569 - Implement custom FBO management

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Robert Mader [:rmader]]

By reusing DMABufSurface we can manage FBOs ourselves instead of using the Wayland EGL platform, attaching buffer using zwp_linux_dmabuf_v1 directly. This has several advantages:

• we can get rid of the surface reordering workaround currently used when hiding surfaces in sync
• better partial damage support, similar to NativeLayerCA::HandlePartialUpdate and WindowSurfaceWaylandMB::HandlePartialUpdate
• more similar to other platforms like MacOS
• more control over GPU memory, fewer depth buffers
• clears the way for YUV support

Comment 1

[Robert Mader [:rmader]]

Attachment: Bug 1718569 - Implement custom FBO management, r=#gfx-reviewers

Comment 2

[Robert Mader [:rmader]]

Attachment: Bug 1718569 - Implement method to create a wl_buffer from a DMABufSurface, r=stransky

In order to allow us to create FBOs ourselves. Right now only implement
it for DMABufSurfaceRGBA. In the future, we will want implement the same
for YUV, see bug 1711461.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0bd1ebf1329
Implement method to create a wl_buffer from a DMABufSurface, r=stransky

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/489ce763c140
Implement custom FBO management, r=jgilbert,gfx-reviewers

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b0bd1ebf1329

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures in /css/css-flexbox/flexbox-align-self-vert-001.xhtml

Backout link: https://hg.mozilla.org/integration/autoland/rev/425f0a769c49c13e046978f508310073e7f18807

Push with failures

Failure log

Comment 7

[Sandor Molnar[:smolnar]]

@Robert, is it right to assume that only after patch in comment 4 is relanded and merged to central this bug can be consider as fixed?

Comment 8

[Robert Mader [:rmader]]

(In reply to Sandor Molnar from comment #7)

@Robert, is it right to assume that only after patch in comment 4 is relanded and merged to central this bug can be consider as fixed?

Right, thanks, the failure was caused by bug 1718570, so relanding this and updating bug 1718570 before landing.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb55f22378a0
Implement custom FBO management, r=jgilbert,gfx-reviewers

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/eb55f22378a0