1718711 - Add testing function for encoding module with stencil XDR

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

Currently module XDR uses legacy XDR, and testcases use codeModule/decodeModule functions, that uses ModuleObject as input/output for XDR.

We should add different functions for module + stencil XDR.
compileToStencil/compileToStencilXDR functions could be used with additional options parameter for module.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1718711 - Part 1: Remove stale requirement around saveIncrementalBytecode and assertEqBytecode. r?nbp!

assertEqBytecode couldn't be used with saveIncrementalBytecode because
we were merging at decode timing.

Bug 1687095 changed it to merge before encoding, and the resulting XDR buffer
becomes same between incremental encode and re-encode.

Depends on D121261

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1718711 - Part 2: Fix help comment for compileToStencil. r?nbp!

Depends on D121262

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1718711 - Part 3: Add module option to compileToStencil. r?nbp!

Depends on D121263

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1718711 - Part 4: Use compileToStencilXDR instead of codeModule. r?nbp!

Depends on D121264

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1718711 - Part 5: Remove codeModule/decodeModule shell functions. r?nbp!

Depends on D121265

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48fdf77fbc02
Part 1: Remove stale requirement around saveIncrementalBytecode and assertEqBytecode. r=nbp
https://hg.mozilla.org/integration/autoland/rev/75eac408c699
Part 2: Fix help comment for compileToStencil. r=nbp
https://hg.mozilla.org/integration/autoland/rev/32023146b793
Part 3: Add module option to compileToStencil. r=nbp
https://hg.mozilla.org/integration/autoland/rev/429677b09999
Part 4: Use compileToStencilXDR instead of codeModule. r=nbp
https://hg.mozilla.org/integration/autoland/rev/73bf3a3d829a
Part 5: Remove codeModule/decodeModule shell functions. r=nbp

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing multiple failures in xdr/module-oom.js

Backout link

Push with failures

Failure log sm build bustage

Failure log jittest

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e8855993da6
Part 1: Remove stale requirement around saveIncrementalBytecode and assertEqBytecode. r=nbp
https://hg.mozilla.org/integration/autoland/rev/f44fe2f1dad6
Part 2: Fix help comment for compileToStencil. r=nbp
https://hg.mozilla.org/integration/autoland/rev/7f73d40c4d95
Part 3: Add module option to compileToStencil. r=nbp
https://hg.mozilla.org/integration/autoland/rev/43ba9d248e20
Part 4: Use compileToStencilXDR instead of codeModule. r=nbp
https://hg.mozilla.org/integration/autoland/rev/9254ffa981e5
Part 5: Remove codeModule/decodeModule shell functions. r=nbp

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2e8855993da6
https://hg.mozilla.org/mozilla-central/rev/f44fe2f1dad6
https://hg.mozilla.org/mozilla-central/rev/7f73d40c4d95
https://hg.mozilla.org/mozilla-central/rev/43ba9d248e20
https://hg.mozilla.org/mozilla-central/rev/9254ffa981e5