Closed Bug 1718711 Opened 3 years ago Closed 3 years ago

Add testing function for encoding module with stencil XDR

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(5 files)

Currently module XDR uses legacy XDR, and testcases use codeModule/decodeModule functions, that uses ModuleObject as input/output for XDR.

We should add different functions for module + stencil XDR.
compileToStencil/compileToStencilXDR functions could be used with additional options parameter for module.

assertEqBytecode couldn't be used with saveIncrementalBytecode because
we were merging at decode timing.

Bug 1687095 changed it to merge before encoding, and the resulting XDR buffer
becomes same between incremental encode and re-encode.

Depends on D121261

Attachment #9233814 - Attachment description: WIP: Bug 1718711 - Part 1: Remove stale requirement around saveIncrementalBytecode and assertEqBytecode. r?tcampbell! → Bug 1718711 - Part 1: Remove stale requirement around saveIncrementalBytecode and assertEqBytecode. r?nbp!
Attachment #9233815 - Attachment description: WIP: Bug 1718711 - Part 2: Fix help comment for compileToStencil. r?nbp! → Bug 1718711 - Part 2: Fix help comment for compileToStencil. r?nbp!
Attachment #9233816 - Attachment description: WIP: Bug 1718711 - Part 3: Add module option to compileToStencil. r?nbp! → Bug 1718711 - Part 3: Add module option to compileToStencil. r?nbp!
Attachment #9233817 - Attachment description: WIP: Bug 1718711 - Part 4: Use compileToStencilXDR instead of codeModule. r?nbp! → Bug 1718711 - Part 4: Use compileToStencilXDR instead of codeModule. r?nbp!
Attachment #9233818 - Attachment description: WIP: Bug 1718711 - Part 5: Remove codeModule/decodeModule shell functions. r?nbp! → Bug 1718711 - Part 5: Remove codeModule/decodeModule shell functions. r?nbp!
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/48fdf77fbc02
Part 1: Remove stale requirement around saveIncrementalBytecode and assertEqBytecode. r=nbp
https://hg.mozilla.org/integration/autoland/rev/75eac408c699
Part 2: Fix help comment for compileToStencil. r=nbp
https://hg.mozilla.org/integration/autoland/rev/32023146b793
Part 3: Add module option to compileToStencil. r=nbp
https://hg.mozilla.org/integration/autoland/rev/429677b09999
Part 4: Use compileToStencilXDR instead of codeModule. r=nbp
https://hg.mozilla.org/integration/autoland/rev/73bf3a3d829a
Part 5: Remove codeModule/decodeModule shell functions. r=nbp

Backed out for causing multiple failures in xdr/module-oom.js

Backout link

Push with failures

Failure log sm build bustage

Failure log jittest

Flags: needinfo?(arai.unmht)
Depends on: 1731761
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/2e8855993da6
Part 1: Remove stale requirement around saveIncrementalBytecode and assertEqBytecode. r=nbp
https://hg.mozilla.org/integration/autoland/rev/f44fe2f1dad6
Part 2: Fix help comment for compileToStencil. r=nbp
https://hg.mozilla.org/integration/autoland/rev/7f73d40c4d95
Part 3: Add module option to compileToStencil. r=nbp
https://hg.mozilla.org/integration/autoland/rev/43ba9d248e20
Part 4: Use compileToStencilXDR instead of codeModule. r=nbp
https://hg.mozilla.org/integration/autoland/rev/9254ffa981e5
Part 5: Remove codeModule/decodeModule shell functions. r=nbp
Regressions: 1742603
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: