1688791 - Remove legacy-XDR code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

The XDRScript and friends functions are deprecated in favour of the Stencil replacements. This code has been error prone to maintain consistent with the ever-changing frontend behaviour. Directly transcoding JSScript lead to a lot of uncertainty about what state should be preserved and what should be dropped.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1688791 - Part 1: Remove saveBytecode option from evaluate shell function. r?tcampbell!

Depends on D121266

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1688791 - Part 2: Remove CompileOptions.useStencilXDR. r?tcampbell!

Depends on D121267

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1688791 - Part 3: Remove stale comment about js::UseOffThreadParseGlobal. r?tcampbell!

Depends on D121268

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1688791 - Part 4: Remove JS::DecodeScript. r?tcampbell!

Depends on D121269

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1688791 - Part 5: Remove JS::EncodeScript. r?tcampbell!

Depends on D121270

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1688791 - Part 6: Remove XDRDecoder and XDROffThreadDecoder. r?tcampbell!

Depends on D121271

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1688791 - Part 7: Remove XDR functions for GC objects. r?tcampbell!

Depends on D121272

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1688791 - Part 8: Remove virtual from XDRState and cast to XDRStencilDecoder when getting options. r?tcampbell!

Depends on D121273

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1688791 - Part 9: Remove stencil/script char from GetScriptTranscodingBuildId. r?tcampbell!

Depends on D121274

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1688791 - Part 10: Remove XDRDecoderBase and XDREncoder aliases. r?tcampbell!

Depends on D121275

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: WIP: Bug 1688791 - Part 11: Remove codeEnum32. r?tcampbell!

Depends on D121276

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58a17b8746e0
Part 1: Remove saveBytecode option from evaluate shell function. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/1f07cd55ccf8
Part 2: Remove CompileOptions.useStencilXDR. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f46fbc282395
Part 3: Remove stale comment about js::UseOffThreadParseGlobal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/4fb6aae7c679
Part 4: Remove JS::DecodeScript. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/b4f9110bd0a1
Part 5: Remove JS::EncodeScript. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/314786485231
Part 6: Remove XDRDecoder and XDROffThreadDecoder. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/574fd2ea3645
Part 7: Remove XDR functions for GC objects. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/cb19cf09ef72
Part 8: Remove virtual from XDRState and cast to XDRStencilDecoder when getting options. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/4ce50a396556
Part 9: Remove stencil/script char from GetScriptTranscodingBuildId. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/63600dd6bc99
Part 10: Remove XDRDecoderBase and XDREncoder aliases. r=tcampbell

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/58a17b8746e0
https://hg.mozilla.org/mozilla-central/rev/1f07cd55ccf8
https://hg.mozilla.org/mozilla-central/rev/f46fbc282395
https://hg.mozilla.org/mozilla-central/rev/4fb6aae7c679
https://hg.mozilla.org/mozilla-central/rev/b4f9110bd0a1
https://hg.mozilla.org/mozilla-central/rev/314786485231
https://hg.mozilla.org/mozilla-central/rev/574fd2ea3645
https://hg.mozilla.org/mozilla-central/rev/cb19cf09ef72
https://hg.mozilla.org/mozilla-central/rev/4ce50a396556
https://hg.mozilla.org/mozilla-central/rev/63600dd6bc99