Closed
Bug 1718952
Opened 3 years ago
Closed 3 years ago
Move JSScript::hasNonSyntacticScope() check from VM to frontend
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(4 files)
After we drop support for cloning between syntactic/non-syntactic scopes, we don't have to check JSScript::hasNonSyntacticScope() in VM side, but can emit different opcodes for each case.
JSOp::BindGName/JSOp::BindNameJSOp::GetGName/JSOp::GetNameJSOp::GlobalThisJSOp::InitGLexical
|
Assignee | |
Comment 1•3 years ago
|
||
Depends on D121278
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D121279
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D121280
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D121281
|
||
Updated•3 years ago
|
Attachment #9233831 -
Attachment description: WIP: Bug 1718952 - Part 1: Move JSScript::hasNonSyntacticScope check for JSOp::BindGName from VM to frontend. r?jandem! → Bug 1718952 - Part 1: Move JSScript::hasNonSyntacticScope check for JSOp::BindGName from VM to frontend. r?jandem!
|
|
||
Updated•3 years ago
|
Attachment #9233832 -
Attachment description: WIP: Bug 1718952 - Part 2: Move JSScript::hasNonSyntacticScope check for JSOp::GetGName from VM to frontend. r?jandem! → Bug 1718952 - Part 2: Move JSScript::hasNonSyntacticScope check for JSOp::GetGName from VM to frontend. r?jandem!
|
|
||
Updated•3 years ago
|
Attachment #9233833 -
Attachment description: WIP: Bug 1718952 - Part 3: Move JSScript::hasNonSyntacticScope check for JSOp::SetGName from VM to frontend. r?jandem! → Bug 1718952 - Part 3: Move JSScript::hasNonSyntacticScope check for JSOp::SetGName from VM to frontend. r?jandem!
|
|
||
Updated•3 years ago
|
Attachment #9233834 -
Attachment description: WIP: Bug 1718952 - Part 4: Add JSOp::NonSyntacticGlobalThis and move JSScript::hasNonSyntacticScope check for JSOp::GlobalThis from VM to frontend. r?jandem! → Bug 1718952 - Part 4: Add JSOp::NonSyntacticGlobalThis and move JSScript::hasNonSyntacticScope check for JSOp::GlobalThis from VM to frontend. r?jandem!
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/0f0206b94ea3 Part 1: Move JSScript::hasNonSyntacticScope check for JSOp::BindGName from VM to frontend. r=jandem https://hg.mozilla.org/integration/autoland/rev/bbfd1d551bb3 Part 2: Move JSScript::hasNonSyntacticScope check for JSOp::GetGName from VM to frontend. r=jandem https://hg.mozilla.org/integration/autoland/rev/c79fad509d16 Part 3: Move JSScript::hasNonSyntacticScope check for JSOp::SetGName from VM to frontend. r=jandem https://hg.mozilla.org/integration/autoland/rev/ffaa22c85a02 Part 4: Add JSOp::NonSyntacticGlobalThis and move JSScript::hasNonSyntacticScope check for JSOp::GlobalThis from VM to frontend. r=jandem
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0f0206b94ea3
https://hg.mozilla.org/mozilla-central/rev/bbfd1d551bb3
https://hg.mozilla.org/mozilla-central/rev/c79fad509d16
https://hg.mozilla.org/mozilla-central/rev/ffaa22c85a02
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•