1718952 - Move JSScript::hasNonSyntacticScope() check from VM to frontend

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

After we drop support for cloning between syntactic/non-syntactic scopes, we don't have to check JSScript::hasNonSyntacticScope() in VM side, but can emit different opcodes for each case.

• JSOp::BindGName / JSOp::BindName
• JSOp::GetGName / JSOp::GetName
• JSOp::GlobalThis
• JSOp::InitGLexical

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1718952 - Part 1: Move JSScript::hasNonSyntacticScope check for JSOp::BindGName from VM to frontend. r?jandem!

Depends on D121278

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1718952 - Part 2: Move JSScript::hasNonSyntacticScope check for JSOp::GetGName from VM to frontend. r?jandem!

Depends on D121279

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1718952 - Part 3: Move JSScript::hasNonSyntacticScope check for JSOp::SetGName from VM to frontend. r?jandem!

Depends on D121280

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1718952 - Part 4: Add JSOp::NonSyntacticGlobalThis and move JSScript::hasNonSyntacticScope check for JSOp::GlobalThis from VM to frontend. r?jandem!

Depends on D121281

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f0206b94ea3
Part 1: Move JSScript::hasNonSyntacticScope check for JSOp::BindGName from VM to frontend. r=jandem
https://hg.mozilla.org/integration/autoland/rev/bbfd1d551bb3
Part 2: Move JSScript::hasNonSyntacticScope check for JSOp::GetGName from VM to frontend. r=jandem
https://hg.mozilla.org/integration/autoland/rev/c79fad509d16
Part 3: Move JSScript::hasNonSyntacticScope check for JSOp::SetGName from VM to frontend. r=jandem
https://hg.mozilla.org/integration/autoland/rev/ffaa22c85a02
Part 4: Add JSOp::NonSyntacticGlobalThis and move JSScript::hasNonSyntacticScope check for JSOp::GlobalThis from VM to frontend. r=jandem

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/0f0206b94ea3
https://hg.mozilla.org/mozilla-central/rev/bbfd1d551bb3
https://hg.mozilla.org/mozilla-central/rev/c79fad509d16
https://hg.mozilla.org/mozilla-central/rev/ffaa22c85a02