1719081 - activity indicator is missing its throbber icon in Customize Toolbar... dialog

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thunderbird 91.0a1 20210703105033 on Windows 8.1

Steps to reproduce:

1. Click onto the toolbar with the right mouse button.
2. Click on "Customize".
3. Find the button for "Activity indicator". It's a blank square, the throbber.

Likely a regression from bug 1683865.

Furthermore, I never see the indicator being active (neither with 78.0 nor with 91.0a1). Is it actually working?

Comment 1

[Henry Wilkes (they/them) [:henry-x]]

I'm guessing you're using a high DPI display. Looking at the patch (https://hg.mozilla.org/comm-central/rev/87d37b027784) I think I left out the chrome path for [e-mail], which is used as part of the img srcset for higher resolution displays. The blank square you saw is the error display for the img.

I never see the indicator being active

I see it sometimes, but not much triggers it for long. I only really notice it on initial loading of an inbox.

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1719081 - Add notloading@2px to chrome path and fix loading@2px icon size. r=aleca

The loading@2px icon would be stretched if the html:img was within a -moz-box because the XUL layout does not handle the CSS width of html:img elements in the same way as a block, flex or grid.

Also a good opportunity to remove some excess XUL boxes.

Comment 3

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1719081 - Add notloading@2x to chrome path and fix loading@2x icon size. r=aleca

The loading@2x icon would be stretched beyond the width of 16px if the html:img was within a -moz-box because the XUL layout does not handle the CSS width of html:img elements in the same way as a block, flex or grid.

Also a good opportunity to remove some excess XUL boxes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c960ee831096
Add notloading@2x to chrome path and fix loading@2x icon size. r=aleca

Comment 5

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1719081 - Follow up: Fix rev c960ee831096 styling for rtl languages. r=aleca

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ecd972f080d7
Follow up: Fix rev c960ee831096 styling for rtl languages. r=aleca

Comment 7

[Geoff Lankow (:darktrojan)]

This bug has a target milestone of 91 so I'm setting the status-thunderbird91 flag to fixed.