1719110 - Don't use PRemoteSpellcheckEngine.CheckAndSuggest sync API on Firefox

Status: RESOLVED FIXED

(Core :: Spelling checker, enhancement)

Description

[Makoto Kato [:m_kato]]

When getting suggestions from spellchecker's result, we use sync IPC (PRemoteSpellcheckEngine.CheckAndSuggest). This is used by showing context menu only on Gecko. So I think that we can remove this IPC if we add async API to get spellchecker suggestions.

And in comm-central's code, CheckCurrentWord and GetSuggestedWord seems to use on spellchecker dialog (content/dialogs/EdSpellCheck.js in mail and suite) that runs on parent process. So c-c won't use this IPC method.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1719110 - Add nsIEditorSpellCheck.suggest to get rid of PRemoteSpellcheckEngine.CheckAndSuggest. r=masayuki

When getting suggestions from spellchecker's result, we use sync IPC
(PRemoteSpellcheckEngine.CheckAndSuggest). This is used by showing context
menu only on Gecko. So I think that we can remove this IPC if we add async API
to get spellchecker suggestions.

And in comm-central's code, CheckCurrentWord and GetSuggestedWord seems to
use on spellchecker dialog (content/dialogs/EdSpellCheck.js in mail and suite)
that runs on parent process. So c-c won't use this IPC method.

So I would like to add the promise version of getting spellchecker's
suggestion.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1719110 - Don't use sync IPC to show suggestion by spellchecker. r=Gijs

To avoid sync IPC, we should use new promise based API instead.

Depends on D119936

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac303b3be0b2
Add nsIEditorSpellCheck.suggest to get rid of PRemoteSpellcheckEngine.CheckAndSuggest. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/ef67a3710b96
Don't use sync IPC to show suggestion by spellchecker. r=Gijs

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ac303b3be0b2
https://hg.mozilla.org/mozilla-central/rev/ef67a3710b96

Comment 5

[Geoff Lankow (:darktrojan)]

FYI there's a typo in one of these patches:
https://hg.mozilla.org/mozilla-central/diff/ef67a3710b96e560a484c7d071ad94acae59e682/browser/base/content/nsContextMenu.js

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/787ed5864d06
Port bug 1719110 - Don't use sync IPC to show suggestion by spellchecker. rs=bustage-fix

Comment 7

[Makoto Kato [:m_kato]]

(In reply to Geoff Lankow (:darktrojan) from comment #5)

FYI there's a typo in one of these patches:
https://hg.mozilla.org/mozilla-central/diff/ef67a3710b96e560a484c7d071ad94acae59e682/browser/base/content/nsContextMenu.js

I filed this as bug 1725599