1541697 - Use Android's system spell checker in GV

Status: NEW

(GeckoView :: General, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

Actually, we turn off hunspell's spellchecker on Android due to package size and etc. Chrome seems to use system's spellchecker, so we may consider that we turn on hunspell or implementing OS's spellchecker.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

If it was enabled, do we have proper UI ready?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This is more about Fenix folks to decide.

Comment 3

[Chris Peterson [:cpeterson]]

TBD: do we need a GV API for the app to toggle Gecko's spellchecker (hunspell or system)?

Comment 4

[Chris Peterson [:cpeterson]]

Can we just rely on the keyboard's spellchecker? If not, James says we should use the system spell checker instead of Hunspell.

Setting this bug to P3 until the Fenix team decides they need spell check.

Comment 5

[Makoto Kato [:m_kato]]

(In reply to Chris Peterson [:cpeterson] from comment #4)

Can we just rely on the keyboard's spellchecker? If not, James says we should use the system spell checker instead of Hunspell.

Gecko's spellchecker interface can select other engines (I still keeps old interfaces). If we add android's system spellchecker implementation to extensions/spellcheck, we can use it.

Comment 6

[Chris Peterson [:cpeterson]]

Adding [geckoview:fenix:m9] whiteboard tag because we need to decide soon whether GV spellcheck support is a blocker for Fennec/Fenix feature parity. It probably isn't a blocker.

Comment 7

[Chris Peterson [:cpeterson]]

Fenix spellcheck issue: https://github.com/mozilla-mobile/fenix/issues/2637

Comment 8

[Prahlad Yeri]

Its August, 2020 already and we still don't have this very basic feature in mobile firefox. Can we decide on either of the two approaches as mentioned by Chris Peterson and stick with it (i.e. Hunspell or android's system spell-checker) ?

Comment 9

[Wesley Aptekar-Cassels]

What's the status of this? I want to use firefox on Android, but keep having to switch to Chrome to get spellcheck.

Comment 11

[Chris Peterson [:cpeterson]]

Tasks and enhancements should have severity N/A.