1719288 - Unexpected check for new emails while the app requests to start offline or online

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Chris GAUDRY [:cmgaudry33]]

Hi,

After playing around with thunderbird 78.11 offline feature, I found out that if I configure the app to ask the user if they want to start offline or online, the app still connects to the same imap server if the user has not yet answered the question.

So if you configure "offline.startup_state" to 2, the application still starts online by default, but the application should start offline by default.

This issue also affects the beta version.

Steps to reproduce :
- set preference "mail.server.server1.login_at_startup" to true (connect to the server at startup) ;
- set preference "mail.server.server1.check_time" to 1 (1 minute) ;
- set preference "offline.startup_state" to 2 (always ask) ;
- start Thunderbird
- wait for the "Connection" dialog
- DO NOT ANSWER THE QUESTION
- wait for 1 minute
- new email will pop up but it should not

Comment 1

[Chris GAUDRY [:cmgaudry33]]

Attachment: bug_1719288_OfflineStartup_jsm.diff

This patch can be applied to the comm-esr78 branch and it seems to be applied also to the comm-beta branch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9229875 [details] [diff] [review]
bug_1719288_OfflineStartup_jsm.diff

Review of attachment 9229875 [details] [diff] [review]:
-----------------------------------------------------------------

Looks alright, thx! r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b27b42f21b72
Unexpected check for new emails while the app requests to start offline or online. r=mkmelin

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9229875 [details] [diff] [review]
bug_1719288_OfflineStartup_jsm.diff

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Unexpected connection attempts at startup when in offline mode
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Small patch, low risk

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9229875 [details] [diff] [review]
bug_1719288_OfflineStartup_jsm.diff

[Triage Comment]
Approved for beta

FWIW, I didn't find any duplicates of this bug

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 91.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/bb98c5054668