1719462 - Add unified Intl::RelativeTimeFormat implementation

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P1)

Description

[Dan Minor [:dminor]]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1672548#c18, it seems like it might be useful to have this sooner rather than later.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1719462 - Add TestBuffer::clear(); r=#platform-i18n-reviewers!

This allows reusing the same buffer multiple times in a test, which
keeps test code simpler.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1719462 - Use ICUError in NumberFormat; r=#platform-i18n-reviewers!

Depends on D121409

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1719462 - Move FormatResultToParts to NumberFormatFields; r=#platform-i18n-reviewers!

This code will be used by RelativeTimeFormat, so we need to move it to a place
where it will be accessible to both NumberFormat and RelativeTimeFormat.

Depends on D121410

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1719462 - Improve comments for NumberFormat::formatToParts; r=#platform-i18n-reviewers!

Depends on D121411

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1719462 - Add intl::RelativeTimeFormat; r=#platform-i18n-reviewers!

Depends on D121412

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1719462 - Use intl::RelativeTimeFormat in SpiderMonkey; r=anba!

This is a work-in-progress because the Auto/Always options are not
handled. This passes all of the jstests except for those related
to the Auto option.

Depends on D121413

Comment 7

[André Bargull [:anba]]

This bug and bug 1648137 modify the same files and we definitely will get some merge conflicts. Which of the two bugs should go first? Do you have any preferences?

Comment 8

[Dan Minor [:dminor]]

Since you have everything reviewed, I think it makes sense for you to land first. Thanks for checking!

Comment 9

[Dan Minor [:dminor]]

Try job here: https://treeherder.mozilla.org/jobs?repo=try&revision=638457de36e0ba51cc49095182983adfac547b26

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b2a624e574d
Add TestBuffer::clear(); r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/dd489d3d26c3
Use ICUError in NumberFormat; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/beb0fb9af533
Move FormatResultToParts to NumberFormatFields; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/483b19b9ecb8
Improve comments for NumberFormat::formatToParts; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/07a088814264
Add intl::RelativeTimeFormat; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/6b0c415e2975
Use intl::RelativeTimeFormat in SpiderMonkey; r=anba,tcampbell

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/1b2a624e574d
https://hg.mozilla.org/mozilla-central/rev/dd489d3d26c3
https://hg.mozilla.org/mozilla-central/rev/beb0fb9af533
https://hg.mozilla.org/mozilla-central/rev/483b19b9ecb8
https://hg.mozilla.org/mozilla-central/rev/07a088814264
https://hg.mozilla.org/mozilla-central/rev/6b0c415e2975