Closed Bug 1719751 Opened 3 years ago Closed 2 years ago

Unify CommonFunctions in SpiderMonkey

Categories

(Core :: Internationalization, task, P3)

task

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

References

Details

(Whiteboard: [i18n-unification], [i18n-unification-help-wanted] )

Attachments

(1 file)

https://searchfox.org/mozilla-central/source/js/src/builtin/intl/CommonFunctions.cpp
https://searchfox.org/mozilla-central/source/js/src/builtin/intl/CommonFunctions.h

There is a single call to ufmtval_getString in CommonFunctions.cpp.

The header file imports #include "unicode/utypes.h", but that could even be a forward declaration now.

The CallICU function should be removed eventually, once we are done unifying.

Greg to set up other bugs blocking this.

Depends on: 1719747
Flags: needinfo?(gtatum)
Whiteboard: [i18n-unification-help-wanted]
Depends on: 1719693
Flags: needinfo?(gtatum)

This bug can be used track the removal of CallICU.

It seems reasonable to move the following check to ICU4CGlue at the same time:

https://searchfox.org/mozilla-central/source/js/src/builtin/intl/CommonFunctions.h#109-112

Depends on: 1719462, 1719735
Whiteboard: [i18n-unification-help-wanted] → [i18n-unification], [i18n-unification-help-wanted]
Assignee: nobody → gtatum
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9a5dd5078f3
Clean up final ICU details in CommonFunctions; r=anba,platform-i18n-reviewers,dminor
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.