1719751 - Unify CommonFunctions in SpiderMonkey

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Greg Tatum [:gregtatum]]

https://searchfox.org/mozilla-central/source/js/src/builtin/intl/CommonFunctions.cpp
https://searchfox.org/mozilla-central/source/js/src/builtin/intl/CommonFunctions.h

There is a single call to ufmtval_getString in CommonFunctions.cpp.

The header file imports #include "unicode/utypes.h", but that could even be a forward declaration now.

The CallICU function should be removed eventually, once we are done unifying.

Comment 1

[Dan Minor [:dminor]]

Greg to set up other bugs blocking this.

Comment 2

[Greg Tatum [:gregtatum]]

js::intl::FormattedValueToString can be removed in Bug 1719693.

Comment 3

[Greg Tatum [:gregtatum]]

This bug can be used track the removal of CallICU.

It seems reasonable to move the following check to ICU4CGlue at the same time:

https://searchfox.org/mozilla-central/source/js/src/builtin/intl/CommonFunctions.h#109-112

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719751 - Clean up final ICU details in CommonFunctions; r?#platform-i18n-reviewers!,anba

Depends on D130800

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9a5dd5078f3
Clean up final ICU details in CommonFunctions; r=anba,platform-i18n-reviewers,dminor

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a9a5dd5078f3