1719542 - Unify Intl APIs in dom/indexedDB/Key.cpp

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Greg Tatum [:gregtatum]]

Difficulty: Small
What it is: A call to create a sort key.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1719542 - Part 1: Collator::GetSortKey calls FillBufferWithICUCall.

Make GetSortKey call FillBufferWithICUCall so we have the same behavior
when resizeing the buffer.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1719542 - Part 2: Add an overloading of FillBufferWithICUCall takes nsTArray.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1719542 - Part 3: Unify IndexedDB key.

For Key::EncodeLocaleString change, the test should be convered in
dom/indexedDB/test/gtest/TestKey.cpp.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1719542 - Part 4: Make calling nsTArray::SetCapacity fallible.

Originally nsCollation::AllocateRawSortKey used an infallible nsTArray1,
however, for IndexedDB it used a fallible nsTArray instead2, so making
SetCapacity fallible.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a3b77c276a9
Part 1: Collator::GetSortKey calls FillBufferWithICUCall. r=platform-i18n-reviewers,anba,gregtatum
https://hg.mozilla.org/integration/autoland/rev/ffa0a9966985
Part 2: Add an overloading of FillBufferWithICUCall takes nsTArray. r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/aaac3fa08626
Part 3: Unify IndexedDB key. r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/0d444a098002
Part 4: Make calling nsTArray::SetCapacity fallible. r=platform-i18n-reviewers,dminor

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9a3b77c276a9
https://hg.mozilla.org/mozilla-central/rev/ffa0a9966985
https://hg.mozilla.org/mozilla-central/rev/aaac3fa08626
https://hg.mozilla.org/mozilla-central/rev/0d444a098002