1719545 - Unify Intl APIs in gfx/thebes/gfxScriptItemizer.cpp

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Greg Tatum [:gregtatum]]

Work: Small
What it is: uscript_getScriptExtensions

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi Greg
I notice in Gecko we already have mozilla::unicode::Script defined in https://searchfox.org/mozilla-central/source/intl/unicharutil/util/nsUnicodeScriptCodes.h, though it is generated by script https://searchfox.org/mozilla-central/source/intl/unicharutil/tools/genUnicodePropertyData.pl.

Should I reuse the mozilla::unicode::Script enum in the Mozilla::intl ? Or should I define new enums in intl/component/src/ ?
This should be the Script defined in ICu4X in https://github.com/unicode-org/icu4x/blob/bf4b5dfc496f5580ebd8d8d5610b3e4bbacee625/components/properties/src/props.rs#L258

Comment 2

[Greg Tatum [:gregtatum]]

Sorry for the delay in the response, I was out of office last week.

It seems reasonable to re-use the nsUnicodeScriptCodes.h enum for now. I don't believe we've scoped out removing that build script, so it should be fine to just get rid of the ICU specific include here. In the if/when we look at unifying the mozilla::unicode::Script it should be obvious where the includes need to be updated.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1719545 - Part 1: Add Script::GetExtensions.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1719545 - Part 2: Unify gfxScriptItemizer.cpp.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1719545 - Part 3: Unify nsIDNService.cpp.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1719545 - Part 4: Fallback to script extension even it only has one extension or its own script code.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c23e1bc87eb8
Part 1: Add Script::GetExtensions. r=anba,platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/6d96c65d9186
Part 2: Unify gfxScriptItemizer.cpp. r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/b501cf0be072
Part 3: Unify nsIDNService.cpp. r=platform-i18n-reviewers,jfkthame,gregtatum,valentin
https://hg.mozilla.org/integration/autoland/rev/701d8641d9f7
Part 4: Fallback to script extension even it only has one extension or its own script code. r=jfkthame

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c23e1bc87eb8
https://hg.mozilla.org/mozilla-central/rev/6d96c65d9186
https://hg.mozilla.org/mozilla-central/rev/b501cf0be072
https://hg.mozilla.org/mozilla-central/rev/701d8641d9f7