1719546 - Unify Intl APIs in layout/base/nsBidi.h

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Greg Tatum [:gregtatum]]

Work: Medium
What it is: Moving the nsBidi abstraction into the unified components, and updating it to match our practices.

Comment 1

[Dan Minor [:dminor]]

This seems like a larger project that Greg or I should take on. Greg will flesh out some more details on this project.

Comment 2

[Greg Tatum [:gregtatum]]

Looking into this, it appears we can mostly copy and paste nsBidi into the intl/src/components and then update the naming and conventions to match the unified intl components. It would be nice to also move the all the definitions into the .cpp file, then we wouldn't have to expose the ICU internals in the header. It appears the constructor is infallible, so it won't need the TryCreate method.

Some new tests will need to be written for it. I don't see anything at this unit level.

I'm updating this as open for contributions beyond Dan or I, since it's adapting an existing abstraction.

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719546 - Create a unified bidi component; r?#platform-i18n-reviewers!

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719546 - Replace nsBidi with mozilla::intl::Bidi; r?#platform-i18n-reviewers!

Depends on D128792

Comment 5

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719546 - Remove nsBidi; r?#platform-i18n-reviewers!

Depends on D128793

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e69fc596f2c3
Create a unified bidi component; r=platform-i18n-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/a1f7ed6c4251
Replace nsBidi with mozilla::intl::Bidi; r=platform-i18n-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/c4d6ffc7e445
Remove nsBidi; r=platform-i18n-reviewers,dminor

Comment 7

[Atila Butkovits]

Backed out for causing SM bustages at Bidi.h.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c00a194497881c0eb6ad3574729c9e275cd26bd5

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=J_j2pRXXQvuS54RhfKgFrg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c4d6ffc7e44521efefa033fe81cba6e1326706f0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=355346808&repo=autoland&lineNumber=88469

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2877faf8d2fa
Create a unified bidi component; r=platform-i18n-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/20965e0af9b3
Replace nsBidi with mozilla::intl::Bidi; r=platform-i18n-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/0f203e8e17f9
Remove nsBidi; r=platform-i18n-reviewers,dminor

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2877faf8d2fa
https://hg.mozilla.org/mozilla-central/rev/20965e0af9b3
https://hg.mozilla.org/mozilla-central/rev/0f203e8e17f9