Closed Bug 1719592 Opened 4 years ago Closed 4 years ago

Tabbar as a white background in system dark theme on Linux

Categories

(Toolkit :: Themes, defect)

All
Linux
defect

Tracking

()

VERIFIED FIXED
91 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox89 --- unaffected
firefox90 --- unaffected
firefox91 --- verified

People

(Reporter: sdk, Assigned: molly)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(2 files, 1 obsolete file)

STR:

  1. Set OS theme to Dark
  2. Set Firefox theme to System theme

AB:

Tabbar background is completely white

EB:

It should use a dark color.

Hmm, okay, I'm on it. Can you add which distro you're using?

Assignee: nobody → mhowell
Status: NEW → ASSIGNED
Flags: needinfo?(mhowell) → needinfo?(contact)

(In reply to Molly Howell (she/her) [:mhowell] from comment #2)

Hmm, okay, I'm on it. Can you add which distro you're using?

I'm on Fedora 34.

Flags: needinfo?(contact)

Also seeing that using Fedora 34, Gnome 40 desktop with the Adwaita-dark OS theme and the Nightly system theme.

Switched to using the Nightly dark theme, fixed the white tab bar and restored the missing menu bar.

Just for the record because it took me a bit to figure this out, the bug does not appear with the default title bar setting, only when the dedicated title bar is enabled (that is, when the "Title Bar" box in the customize tab is checked).

Regressed by: 1699419
Has Regression Range: --- → yes

In bug 1699419 I moved a hardcoded color from the Mac CSS because it seemed
like a reasonable default. As it turns out, that color might be a reasonable
default for macOS, but it certainly isn't on some other systems. We're already
determining a nice default toolbar background color, so let's just use that
instead and avoid the whole issue.

I'm gonna back out bug 1699419 to stop the bleeding for now until we can get this sorted out more thoroughly.

Keywords: leave-open

Set release status flags based on info from the regressing bug 1699419

Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d1ecf2e4fa01 Back out bug 1699419 for causing multiple tab bar background regressions. r=harry,desktop-theme-reviewers

Bug 1699419 is now WONTFIX, so we can close this.

Keywords: leave-open
Blocks: 1719627
Attachment #9230355 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Flags: qe-verify+

Was re-introducing a not (-moz-proton) block here intentional? I assume not...

Flags: needinfo?(mhowell)

Oh. No, I just didn't check the contents of the backout commit closely enough. That can go.

Flags: needinfo?(mhowell)
See Also: → 1722586

I can seem to be able to reproduce the issue. Can you please verify the fix using latest beta? You can find the build
here.

Flags: needinfo?(contact)

(In reply to Oana Botisan, Desktop Release QA from comment #15)

I can seem to be able to reproduce the issue. Can you please verify the fix using latest beta? You can find the build
here.

It looks fixed on beta.

Flags: needinfo?(contact)

According to comment 16, I will mark this bug as verified fixed. Thank you for testing this.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: