Tabbar as a white background in system dark theme on Linux
Categories
(Toolkit :: Themes, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox89 | --- | unaffected |
firefox90 | --- | unaffected |
firefox91 | --- | verified |
People
(Reporter: sdk, Assigned: molly)
References
(Regression)
Details
(Keywords: nightly-community, regression)
Attachments
(2 files, 1 obsolete file)
STR:
- Set OS theme to Dark
- Set Firefox theme to System theme
AB:
Tabbar background is completely white
EB:
It should use a dark color.
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 1•4 years ago
•
|
||
I found the changeset that introduced it https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=edc4528a66ffce821b3c981469c5274fbc71b534&tochange=0cf557aafeaaa723f340932fb316c91d5557b0dc
Assignee | ||
Comment 2•4 years ago
|
||
Hmm, okay, I'm on it. Can you add which distro you're using?
Reporter | ||
Comment 3•4 years ago
|
||
(In reply to Molly Howell (she/her) [:mhowell] from comment #2)
Hmm, okay, I'm on it. Can you add which distro you're using?
I'm on Fedora 34.
Comment 4•4 years ago
|
||
Also seeing that using Fedora 34, Gnome 40 desktop with the Adwaita-dark OS theme and the Nightly system theme.
Switched to using the Nightly dark theme, fixed the white tab bar and restored the missing menu bar.
Assignee | ||
Comment 5•4 years ago
|
||
Just for the record because it took me a bit to figure this out, the bug does not appear with the default title bar setting, only when the dedicated title bar is enabled (that is, when the "Title Bar" box in the customize tab is checked).
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
In bug 1699419 I moved a hardcoded color from the Mac CSS because it seemed
like a reasonable default. As it turns out, that color might be a reasonable
default for macOS, but it certainly isn't on some other systems. We're already
determining a nice default toolbar background color, so let's just use that
instead and avoid the whole issue.
Assignee | ||
Comment 7•4 years ago
|
||
I'm gonna back out bug 1699419 to stop the bleeding for now until we can get this sorted out more thoroughly.
Assignee | ||
Comment 8•4 years ago
|
||
Comment 9•4 years ago
|
||
Set release status flags based on info from the regressing bug 1699419
Comment 10•4 years ago
|
||
Updated•4 years ago
|
Comment 12•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Comment 13•4 years ago
|
||
Was re-introducing a not (-moz-proton)
block here intentional? I assume not...
Assignee | ||
Comment 14•4 years ago
|
||
Oh. No, I just didn't check the contents of the backout commit closely enough. That can go.
Comment 15•4 years ago
|
||
I can seem to be able to reproduce the issue. Can you please verify the fix using latest beta? You can find the build
here.
Reporter | ||
Comment 16•4 years ago
|
||
(In reply to Oana Botisan, Desktop Release QA from comment #15)
I can seem to be able to reproduce the issue. Can you please verify the fix using latest beta? You can find the build
here.
It looks fixed on beta.
Comment 17•4 years ago
•
|
||
According to comment 16, I will mark this bug as verified fixed. Thank you for testing this.
Description
•