Closed
Bug 1719667
Opened 3 years ago
Closed 3 years ago
Do not set recommended preferences when not wanted
Categories
(Remote Protocol :: Agent, defect, P2)
Remote Protocol
Agent
Tracking
(firefox91 fixed)
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: whimboo, Assigned: jdescottes)
References
Details
(Whiteboard: [bidi-m1-mvp])
Attachments
(1 file)
This bug came up for my work on bug 1693805 where CDP tries to set recommended preferences and by default all common recommended preferences are set. But this should not be done given that in case of running Marionette tests in CI we turn off this feature via marionette.prefs.recommended = false:
As such we have to do follow-up work from bug 1718052, which shared the usage of recommended prefs with the Remote Agent. Means we could use remote.prefs.recommended in RecommendedPrefs.jsm.
Note that this pref is only turned off in our CI, so any automation that is using geckodriver isn't affected.
|
Reporter | |
Updated•3 years ago
|
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
|
|
Reporter | |
Updated•3 years ago
|
Whiteboard: [bidi-m1-mvp] → [webdriver:triage]
|
|
Assignee | |
Comment 1•3 years ago
|
||
Depends on D119073
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5c04de0bab3
[remote] Do not set recommended preferences when not wanted r=webdriver-reviewers,whimboo
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
|
|
Assignee | |
Updated•3 years ago
|
Points: --- → 2
Priority: -- → P2
|
|
Assignee | |
Updated•3 years ago
|
Whiteboard: [webdriver:triage] → [bidi-m1-mvp]
You need to log in
before you can comment on or make changes to this bug.
Description
•