1693805 - Add support for handling BiDi connections

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the work on bug 1693802 we should have a connection module that should allow us to implement accepting an incoming connection, and closing it.

Note that it won't have to handle the session yet. Another bug will be filed for that.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1693805 - [remote] Delay registration of CDP path handlers until protocol gets started.

While the constructor should only do the initialization
of the class, anything else related to the HTTP server
should be delayed until the protocol gets actually
started.

Further the protocol constructor needs the reference
to the Remote Agent itself instead of only the
HTTP server.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1693805 - [remote] Reorganize RemoteAgent component.

Depends on D119264

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1693805 - [remote] Add support for handling WebDriver BiDi connections.

Depends on D119265

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1a48314a6f2
[remote] Delay registration of CDP path handlers until protocol gets started. r=webdriver-reviewers,jgraham,jdescottes
https://hg.mozilla.org/integration/autoland/rev/34acfc33e07a
[remote] Reorganize RemoteAgent component. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/946c4ba45c96
[remote] Add support for handling WebDriver BiDi connections. r=webdriver-reviewers,jgraham,jdescottes

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing multiple failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/744f95915c784e236b10c18d1ae71a90ded9a76a

Push with failures

Lint failure log

Test telemetry failure log

Mochitest failure log #1

Mochitest failure log #2

Xpc failure log

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This failure came in due to the rebase that I did before pushing to autoland. With that we set the recommended preferences in the constructor of the CDP module, which gets immediately loaded now. As such this needs to be delayed until CDP actually gets started.

The underlying problem needs to be fixed, and I filed bug 1719667 for that work.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c883527d366
[remote] Delay registration of CDP path handlers until protocol gets started. r=webdriver-reviewers,jgraham,jdescottes
https://hg.mozilla.org/integration/autoland/rev/0a1b4a96c1cf
[remote] Reorganize RemoteAgent component. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/4b6ec8e2cf78
[remote] Add support for handling WebDriver BiDi connections. r=webdriver-reviewers,jgraham,jdescottes

Comment 8

[Alexandru Michis [:malexandru]]

Backed out 3 changesets (Bug 1693805) for causing bc failures in browser_all_files_referenced.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/6fa18226d738435952f76e2eeb7ae69ebdca1e2f
Push with failures, failure log.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's sad, but WebDriverBiDiConnection.jsm isn't used at this point. It means this browser chrome test always fail, and I have to wait with the push until bug 1691446 has a reviewed patch.

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/e2c9d9f0aad2
Backed out 3 changesets for causing bc failures in browser_all_files_referenced.js

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Julian had the idea to just remove the inclusion of the module from the jar.mn file for now. That actually fixes the test. I'll try to land again, and hopefully it works this time.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d23409efae3
[remote] Delay registration of CDP path handlers until protocol gets started. r=webdriver-reviewers,jgraham,jdescottes
https://hg.mozilla.org/integration/autoland/rev/12bc4a9548c2
[remote] Reorganize RemoteAgent component. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/7102bff7059a
[remote] Add support for handling WebDriver BiDi connections. r=webdriver-reviewers,jgraham,jdescottes

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5d23409efae3
https://hg.mozilla.org/mozilla-central/rev/12bc4a9548c2
https://hg.mozilla.org/mozilla-central/rev/7102bff7059a