1719707 - [Onboarding] Include screen order in about:welcome telemetry

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to add screen order inside messageid sent to telemetry. See Bug 1691942

Capture of slack thread discussion:
We need to add something like a step_id to go with message_ids . Every time we change the message ID, we break our dashboards and charts. Not to mention, it’s impossible to remember all of them.In order to plot a chart over 3 months, we have to include like 15 message IDs.If we had step 1, step 2, step 3, etc. We could build our charts from that and it wouldn’t break each time. We could then segment on message ID to see more details.

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1719707 - Include screen order in message id

Patch appends screen order in message id to be passed in Impression and Click telemetry from respective screen. This is useful to keep onboarding engagement dashboard consistent across releases by using message id that begins with 'feature id_screen order_%'

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c175251949b4
Include screen order in message id r=andreio

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c175251949b4

Comment 4

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following using a new profile with non-default, not-pinned Firefox Nightly 92.0a1 (Build ID: 20210718212857) and Firefox Beta 91.0b4 (Build ID: 20210718185934) on Windows 10 x64, macOS 11.4, and Ubuntu Linux x64:

For the "about:welcome" landing page:

• The "IMPRESSION" ping contains the "message_id":"DEFAULT_ABOUTWELCOME_PROTON_0_AW_PIN_FIREFOX" string;
• The "CLICK_BUTTON" ping from both the primary and the secondary buttons contains the "message_id":"DEFAULT_ABOUTWELCOME_PROTON_0_AW_PIN_FIREFOX" string;

For the 1st "about:welcome" slide:

• The "IMPRESSION" ping contains the "message_id":"DEFAULT_ABOUTWELCOME_PROTON_1_AW_SET_DEFAULT" string;
• The "CLICK_BUTTON" ping from both the primary and the secondary buttons contains the "message_id":"DEFAULT_ABOUTWELCOME_PROTON_1_AW_SET_DEFAULT" string;

For the 2nd "about:welcome" slide:

• The "IMPRESSION" ping contains the "message_id":"DEFAULT_ABOUTWELCOME_PROTON_2_AW_IMPORT_SETTINGS" string;
• The "CLICK_BUTTON" ping from both the primary and the secondary buttons contains the "message_id":"DEFAULT_ABOUTWELCOME_PROTON_2_AW_IMPORT_SETTINGS" string;

For the 3rd "about:welcome" slide:

• The "IMPRESSION" ping contains the "message_id":"DEFAULT_ABOUTWELCOME_PROTON_3_AW_CHOOSE_THEME" string;
• The "CLICK_BUTTON" ping from both the primary and the secondary buttons contains the "message_id":"DEFAULT_ABOUTWELCOME_PROTON_3_AW_CHOOSE_THEME" string;
• The "CLICK_BUTTON" ping from each of the available themes contains the "message_id":"DEFAULT_ABOUTWELCOME_PROTON_3_AW_CHOOSE_THEME" string.

I have also verified for the cases where the Firefox browser is already set as default but not pinned, and it is already set as default and pinned.