Closed Bug 1867627 Opened 10 months ago Closed 9 months ago

Send individual components for message impression telemetry

Categories

(Firefox :: Messaging System, task, P1)

task
Points:
5

Tracking

()

RESOLVED FIXED
123 Branch
Iteration:
123.1 - Dec 18 - Dec 29
Tracking Status
firefox123 --- fixed

People

(Reporter: Mardak, Assigned: nsauermann)

References

(Blocks 1 open bug)

Details

(Whiteboard: [omc])

Attachments

(1 file)

Currently the message id is a concatenation of various components: ${props.message_id}_${order}_${screen.id}_${screenInitials}:
https://searchfox.org/mozilla-central/rev/d84469b005106c5ab0f65e283f71c1415ce76c54/browser/components/aboutwelcome/content-src/components/MultiStageAboutWelcome.jsx#67-71

We can keep backwards compatibility (if desired) by also sending the individual components. These various parts were added for different requests, e.g., treat message showing on screen 1 vs 2 differently, but made it trickier to query without, e.g., treat same screen independent of index. See bug 1619694, bug 1719707, bug 1790655, etc.

Kinda related but could be split out are related telemetry that happen to be separate call sites, e.g., for actions, that might want some cleanup so that each place consistently passes in the components:
https://searchfox.org/mozilla-central/rev/d84469b005106c5ab0f65e283f71c1415ce76c54/browser/components/aboutwelcome/content-src/components/MultiStageAboutWelcome.jsx#377-378,430-434

Now with glean bug 1825863, it should hopefully be relatively straightforward to add additional fields for each component:

https://searchfox.org/mozilla-central/rev/d84469b005106c5ab0f65e283f71c1415ce76c54/browser/components/newtab/metrics.yaml#757-791

Depends on: 1825863
Assignee: nobody → nsauermann
Iteration: --- → 122.2 - Dec 4 - Dec 15
Points: --- → 5
Priority: -- → P1
Attachment #9368761 - Attachment description: WIP: Bug 1867627 - Send individual components for message telemetry, e.g., impression, click → Bug 1867627 - Send individual components for message telemetry, e.g., impression, click
Iteration: 122.2 - Dec 4 - Dec 15 → 123.1 - Dec 18 - Dec 29
Summary: Send individual components for message telemetry, e.g., impression, click → Send individual components for message impression telemetry
Attachment #9368761 - Attachment description: Bug 1867627 - Send individual components for message telemetry, e.g., impression, click → Bug 1867627 - Send individual components for message impression telemetry
Blocks: 1870893
Attachment #9368761 - Attachment description: Bug 1867627 - Send individual components for message impression telemetry → Bug 1867627 - Send individual components for message telemetry, e.g., impression, click
Flags: qe-verify+
Pushed by nsauermann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ea801d24a162 Send individual components for message telemetry, e.g., impression, click r=Mardak,dmose,omc-reviewers
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: