1719754 - BrowserGlue fxa login status code fails if fxa button isn't in the toolbox

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

Spotted in the log output in bug 1719175.

https://searchfox.org/mozilla-central/rev/1add3985d32470582ce83f40a212a976e4fc7da5/browser/components/BrowserGlue.jsm#4218

  _updateFxaBadges(win) {
    let fxaButton = win.document.getElementById("fxa-toolbar-menu-button");
    let badge = fxaButton.querySelector(".toolbarbutton-badge");
    ...
  }

produces:

TypeError: fxaButton is null

if the button is customized.

We should be nullchecking fxaButton before using it in this method, because the adding/clearing of the notifications should still work on the app menu if the fxa button is not present.

Emma or Molly, are you in a position to work on this?

Comment 1

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1719754 - Don't fail to update the FxA badge status when the toolbar icon doesn't exist at all. r=emalysz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bbaeeac0206
Don't fail to update the FxA badge status when the toolbar icon doesn't exist at all. r=emalysz

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9bbaeeac0206

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mhowell, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Molly Howell (she/her) (mostly inactive)]

I don't feel like this one really needs an uplift.