1719895 - Downloads panel should not open when opening a PDF sending CD: attachment

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P3)

Description

[Micah [:mtigley] (she/her)]

Steps to Reproduce

1. Ensure browser.download.improvements_to_download_panel pref is set to true.
2. Ensure "Save files to <path>" option is selected from about:preferences and that PDFs are configured to open in Firefox
3. Try opening a PDF that sends CD: attachment. (eg. open any google doc and use File > Print inside the gdocs UI)

Expected Results
File should be loaded directly from internet instead of local disk. The download panel should not open.

Actual Results
Download panel opens

Notes
This will be resolved by Bug 1719892, but we should also make sure we check this issue is fixed when that's done.

Comment 1

[:Gijs (he/him)]

Fixing bug 1719892 will fix this bug, but we may want to separately make sure that for downloads that we handle internally, we don't open the downloads panel - which should be doable by adding a condition to the code that pops up the download panel such that we don't do it for files we handleInternally.

Comment 2

[Neil Deakin]

Should be fixed by 1719892.

Comment 3

[Catalin Sasca, Desktop QA [:csasca]]

Hey guys, wanted to verify this issue but it seems that the download panel still launches after printing a file to pdf in gdoc while on Firefox 96.0. Here's an attachment with the steps I did. Any idea Neil?

Comment 4

[:Gijs (he/him)]

Is the downloads improvement pref enabled in that video? I can't tell.

If so, I think this is bug 1742648?

Comment 5

[Catalin Sasca, Desktop QA [:csasca]]

Yes, the downloads improvement pref was set to true. So then the download panel issue is related to bug 1742648?

Comment 6

[:Gijs (he/him)]

(In reply to Catalin Sasca, QA [:csasca] from comment #5)

Yes, the downloads improvement pref was set to true. So then the download panel issue is related to bug 1742648?

Well, you tested on google docs, and bug 1742648 is specifically about the exemption of gdocs/gsheets from the fix in bug 1719892. So yes, I think the fact that gdocs still has the problem described here is covered by bug 1742648.

This should work as expected for e.g. the PDF link at the top of https://mime.ty.ax/ .

That said, perhaps it's worth reopening this bug and addressing separately the fact that we still open the downloads panel for files that are handled internally. We should be able to avoid this by checking for internal handling on the download object whose notification is currently triggering the opening of the panel. Neil/Micah, what do you think?

Comment 7

[Neil Deakin]

Yes, bug 1742648 covers the issue for google documents/sheets/etc for which a workaround is currently being applied to disable opening them internally.

Comment 8

[Catalin Sasca, Desktop QA [:csasca]]

Ok, so given the circumstances, I reverified that the panel is not opening anymore if downloading the pdf from https://mime.ty.ax/ while on Firefox 96.0. Tests were performed on macOS 12.1, Ubuntu 20.04 and Windows 11.