1742648 - Remove special case for handling pdf in subframes (such as printing a google document/sheet) so that they open directly in the pdf viewer

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, enhancement)

Comment 1

[Adrian Florinescu [:aflorinescu]]

Apparently, the expected result here would be that Gdoc/Gsheet Print as pdf would not be treated as a download case, but rather directly opening as in-content attachment: assuming this applies only for the default action: Open In Firefox.

Actual Result now, given 101.0a1 (2022-04-13) is that the print Gdoc/Gsheet will trigger a download, afterwhich the file will be opened with the set handler, regardless if the action for PDF is set to be Open In Firefox. (bug 1719892 and bug 1719895 didn't fix this instance)

Comment 2

[:Gijs (away/busy until Mar 10)]

With bug 1756980 fixed, I think we can remove this specialcase now...

Comment 3

[Neil Deakin]

Attachment: Bug 1742648, remove special case for downloading pdfs in subframes, r=mtigley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ac722cbe7c1
remove special case for downloading pdfs in subframes, r=mtigley

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0ac722cbe7c1

Comment 6

[Neil Deakin]

Comment on attachment 9274656 [details]
Bug 1742648, remove special case for downloading pdfs in subframes, r=mtigley

Beta/Release Uplift Approval Request

• User impact if declined: PDFs that open in subframes such as print/export from google doc/sheet/etc are downloaded into a separate tab rather than opened inline using the internal pdf viewer
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This removes a workaround that was fixed by bug 1756980. That change for that bug is already in 101.
• String changes made/needed: None
• Is Android affected?: No

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9274656 [details]
Bug 1742648, remove special case for downloading pdfs in subframes, r=mtigley

Approved for 101.0b4.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/36afd39b497c

Comment 9

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Managed to reproduce this issue with the affected build 101.0a1(20220412213655) on Windows 11.

Confirming this issue as verified fixed with 101.0b4(20220508185621) and 102.0a1(20220508190220) using macOS 12, Windows 11 and Ubuntu 20.