Closed Bug 1719938 Opened 3 years ago Closed 2 years ago

Remove remaining (non-negated) -moz-proton media queries and the media query implementation

Categories

(Firefox :: General, task)

Product:
Firefox
Component:
General
Platform:
Desktop
All
Type:
task
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox91 --- wontfix
firefox96 --- fixed

People

(Reporter: Gijs, Assigned: lamoure6, NeedInfo)

References

Details

(Whiteboard: [proton-cleanups])

Attachments

(1 file)

Bug 1719938 - Removed remaining (non-negated) -moz-proton media queries. r=mhowell,mtigley
48 bytes, text/x-phabricator-request
Details | Review

These: https://searchfox.org/mozilla-central/search?q=media+%28-moz-proton%29&path=&case=false&regexp=false

should be superfluous, and the styling should be reconciled into similar rules outside of the media query where possible, with the media query removed.

We can then remove the implementation as well, once bug 1703630 is also fixed.

Blocks: 1719939

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: General → Audio/Video: Playback
Product: Firefox → Core

Bad bugbug. :-(

Component: Audio/Video: Playback → General
Product: Core → Firefox
Assignee: nobody → lamoure6
Status: NEW → ASSIGNED
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0711ae54877b
Removed remaining (non-negated) -moz-proton media queries. r=mhowell,mtigley,emilio

Backed out for bustages on media_features.rs

[task 2021-09-20T19:31:51.284Z] 19:31:51     INFO -  error: unused macro definition
[task 2021-09-20T19:31:51.284Z] 19:31:51     INFO -     --> servo/components/style/gecko/media_features.rs:662:1
[task 2021-09-20T19:31:51.284Z] 19:31:51     INFO -      |
[task 2021-09-20T19:31:51.284Z] 19:31:51     INFO -  662 | / macro_rules! bool_pref_feature {
[task 2021-09-20T19:31:51.284Z] 19:31:51     INFO -  663 | |     ($feature_name:expr, $pref:tt) => {{
[task 2021-09-20T19:31:51.285Z] 19:31:51     INFO -  664 | |         fn __eval(_: &Device, query_value: Option<bool>, _: Option<RangeOrOperator>) -> bool {
[task 2021-09-20T19:31:51.285Z] 19:31:51     INFO -  665 | |             let value = static_prefs::pref!($pref);
[task 2021-09-20T19:31:51.285Z] 19:31:51     INFO -  ...   |
[task 2021-09-20T19:31:51.285Z] 19:31:51     INFO -  675 | |     }};
[task 2021-09-20T19:31:51.285Z] 19:31:51     INFO -  676 | | }
[task 2021-09-20T19:31:51.285Z] 19:31:51     INFO -      | |_^
[task 2021-09-20T19:31:51.285Z] 19:31:51     INFO -      |
[task 2021-09-20T19:31:51.285Z] 19:31:51     INFO -      = note: `-D unused-macros` implied by `-D warnings`
[task 2021-09-20T19:31:51.286Z] 19:31:51    ERROR -  error[E0308]: mismatched types
[task 2021-09-20T19:31:51.286Z] 19:31:51     INFO -     --> servo/components/style/gecko/media_features.rs:683:60
[task 2021-09-20T19:31:51.286Z] 19:31:51     INFO -      |
[task 2021-09-20T19:31:51.286Z] 19:31:51     INFO -  683 |   pub static MEDIA_FEATURES: [MediaFeatureDescription; 60] = [
[task 2021-09-20T19:31:51.286Z] 19:31:51     INFO -      |  ____________________________________________________________^
[task 2021-09-20T19:31:51.286Z] 19:31:51     INFO -  684 | |     feature!(
[task 2021-09-20T19:31:51.286Z] 19:31:51     INFO -  685 | |         atom!("width"),
[task 2021-09-20T19:31:51.287Z] 19:31:51     INFO -  686 | |         AllowsRanges::Yes,
[task 2021-09-20T19:31:51.287Z] 19:31:51     INFO -  ...   |
[task 2021-09-20T19:31:51.287Z] 19:31:51     INFO -  928 | |     lnf_int_feature!(atom!("-moz-system-dark-theme"), SystemUsesDarkTheme),
[task 2021-09-20T19:31:51.287Z] 19:31:51     INFO -  929 | | ];
[task 2021-09-20T19:31:51.287Z] 19:31:51     INFO -      | |_^ expected an array with a fixed size of 60 elements, found one with 58 elements
[task 2021-09-20T19:31:51.287Z] 19:31:51     INFO -      |
[task 2021-09-20T19:31:51.287Z] 19:31:51     INFO -      = note: expected array `[MediaFeatureDescription; 60]`
[task 2021-09-20T19:31:51.288Z] 19:31:51     INFO -                 found array `[MediaFeatureDescription; 58]`
[task 2021-09-20T19:31:51.288Z] 19:31:51     INFO -  For more information about this error, try `rustc --explain E0308`.
[task 2021-09-20T19:31:51.288Z] 19:31:51     INFO -  error: could not compile `style` due to 2 previous errors
Flags: needinfo?(lamoure6)
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5523334143d9
Removed remaining (non-negated) -moz-proton media queries. r=mhowell,mtigley,emilio

Backed out for failures on browser_parsable_css.js

[task 2021-09-20T23:16:15.176Z] 23:16:15     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-svg-marker-anon-child’.  Ruleset ignored due to bad selector." on resource://gre/res/svg.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
[task 2021-09-20T23:16:15.178Z] 23:16:15     INFO - Buffered messages finished
[task 2021-09-20T23:16:15.180Z] 23:16:15     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for chrome://browser/skin/browser.css: Expected media feature name but found ‘-moz-proton-places-tooltip’. - 
[task 2021-09-20T23:16:15.181Z] 23:16:15     INFO - Stack trace:
[task 2021-09-20T23:16:15.182Z] 23:16:15     INFO - chrome://mochikit/content/browser-test.js:test_ok:1336
[task 2021-09-20T23:16:15.183Z] 23:16:15     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:messageIsCSSError:250
[task 2021-09-20T23:16:15.183Z] 23:16:15     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:471
[task 2021-09-20T23:16:15.185Z] 23:16:15     INFO - Ignored error "Unknown property ‘-moz-context-properties’.  Declaration dropped." on jar:file:///builds/worker/workspace/build/application/firefox/browser/features/formautofill@mozilla.org.xpi!/chrome/content/skin/autocomplete-item-shared.css because of whitelist item {"sourceName":"/\\b(minimal-xul|html|mathml|ua|forms|svg|manageDialog|autocomplete-item-shared|formautofill)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2021-09-20T23:16:15.187Z] 23:16:15     INFO - Ignored error "Unknown property ‘-moz-context-properties’.  Declaration dropped." on jar:file:///builds/worker/workspace/build/application/firefox/browser/features/formautofill@mozilla.org.xpi!/chrome/content/skin/autocomplete-item-shared.css because of whitelist item {"sourceName":"/\\b(minimal-xul|html|mathml|ua|forms|svg|manageDialog|autocomplete-item-shared|formautofill)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2021-09-20T23:16:15.189Z] 23:16:15     INFO - Ignored error "Unknown property ‘-moz-context-properties’.  Declaration dropped." on jar:file:///builds/worker/workspace/build/application/firefox/browser/features/formautofill@mozilla.org.xpi!/chrome/content/manageDialog.css because of whitelist item {"sourceName":"/\\b(minimal-xul|html|mathml|ua|forms|svg|manageDialog|autocomplete-item-shared|formautofill)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2021-09-20T23:16:15.190Z] 23:16:15     INFO - Ignored error "Unknown property ‘-moz-context-properties’.  Declaration dropped." on jar:file:///builds/worker/workspace/build/application/firefox/browser/features/formautofill@mozilla.org.xpi!/chrome/content/formautofill.css because of whitelist item {"sourceName":"/\\b(minimal-xul|html|mathml|ua|forms|svg|manageDialog|autocomplete-item-shared|formautofill)\\.css$/i","errorMessage":"/Unknown property.*-moz-/i","isFromDevTools":false,"used":true}
[task 2021-09-20T23:16:15.191Z] 23:16:15     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-09-20T23:16:15.192Z] 23:16:15     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | All the styles (256) loaded without errors. - Got 1, expected +0
[task 2021-09-20T23:16:15.192Z] 23:16:15     INFO - Stack trace:
[task 2021-09-20T23:16:15.192Z] 23:16:15     INFO - chrome://mochikit/content/browser-test.js:test_is:1364
[task 2021-09-20T23:16:15.192Z] 23:16:15     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:472
[task 2021-09-20T23:16:15.193Z] 23:16:15     INFO - Leaving test bound checkAllTheCSS
[task 2021-09-20T23:16:15.194Z] 23:16:15     INFO - GECKO(2000) | MEMORY STAT | vsize 3556MB | residentFast 925MB | heapAllocated 727MB
[task 2021-09-20T23:16:15.195Z] 23:16:15     INFO - TEST-OK | browser/base/content/test/static/browser_parsable_css.js | took 527ms
Flags: needinfo?(lamoure6)
Flags: needinfo?(lamoure6)
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7862600f1fb9
Removed remaining (non-negated) -moz-proton media queries. r=mhowell,mtigley,emilio

https://hg.mozilla.org/mozilla-central/rev/7862600f1fb9

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: