Open Bug 1719949 Opened 5 months ago Updated 5 days ago

Intermittent browser/components/downloads/test/browser/browser_downloads_panel_context_menu.js | Cleanup function threw an exception - UnknownError: Unexpected error: NS_ERROR_FAILURE

Categories

(Firefox :: Downloads Panel, defect, P5)

defect

Tracking

()

People

(Reporter: intermittent-bug-filer, Unassigned, NeedInfo)

References

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [stockwell disabled])

Attachments

(1 file)

Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=344836279&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/KXqgDslbSrORPHN1cqvK-w/runs/0/artifacts/public/logs/live_backing.log


[task 2021-07-10T01:14:51.739Z] 01:14:51     INFO - TEST-START | browser/components/downloads/test/browser/browser_downloads_panel_context_menu.js
[task 2021-07-10T01:14:52.090Z] 01:14:52     INFO - TEST-INFO | started process screenshot
[task 2021-07-10T01:14:52.175Z] 01:14:52     INFO - TEST-INFO | screenshot: exit 0
[task 2021-07-10T01:14:52.175Z] 01:14:52     INFO - Buffered messages logged at 01:14:51
[task 2021-07-10T01:14:52.176Z] 01:14:52     INFO - Entering test bound test_setUp
[task 2021-07-10T01:14:52.176Z] 01:14:52     INFO - TEST-PASS | browser/components/downloads/test/browser/browser_downloads_panel_context_menu.js | At the start of the test, there should be 0 downloads - 
[task 2021-07-10T01:14:52.177Z] 01:14:52     INFO - Created download directory: C:\Users\task_1625876514\AppData\LocalLow\Mozilla\Temp-{b9d6ccb3-e220-4dcd-9451-2994e0c53859}\testsavedir2247668850
[task 2021-07-10T01:14:52.178Z] 01:14:52     INFO - TEST-PASS | browser/components/downloads/test/browser/browser_downloads_panel_context_menu.js | Created C:\Users\task_1625876514\AppData\LocalLow\Mozilla\Temp-{b9d6ccb3-e220-4dcd-9451-2994e0c53859}\testsavedir2247668850\downloaded.pdf - 
[task 2021-07-10T01:14:52.178Z] 01:14:52     INFO - Created downloaded PDF file at:C:\Users\task_1625876514\AppData\LocalLow\Mozilla\Temp-{b9d6ccb3-e220-4dcd-9451-2994e0c53859}\testsavedir2247668850\downloaded.pdf
<...>
[task 2021-07-10T01:14:52.196Z] 01:14:52     INFO - TEST-PASS | browser/components/downloads/test/browser/browser_downloads_panel_context_menu.js | Expected no errors verifying context menu items - 
[task 2021-07-10T01:14:52.196Z] 01:14:52     INFO - Leaving test bound Canceled PDF download
[task 2021-07-10T01:14:52.196Z] 01:14:52     INFO - removing C:\Users\task_1625876514\AppData\Local\Temp\dm-ui-test.file
[task 2021-07-10T01:14:52.196Z] 01:14:52     INFO - Buffered messages finished
[task 2021-07-10T01:14:52.197Z] 01:14:52     INFO - TEST-UNEXPECTED-FAIL | browser/components/downloads/test/browser/browser_downloads_panel_context_menu.js | Cleanup function threw an exception - UnknownError: Unexpected error: NS_ERROR_FAILURE
[task 2021-07-10T01:14:52.197Z] 01:14:52     INFO - GECKO(7220) | MEMORY STAT | vsize 2104280MB | vsizeMaxContiguous 65114789MB | residentFast 305MB | heapAllocated 131MB
[task 2021-07-10T01:14:52.198Z] 01:14:52     INFO - TEST-OK | browser/components/downloads/test/browser/browser_downloads_panel_context_menu.js | took 405ms
[task 2021-07-10T01:14:52.199Z] 01:14:52     INFO - checking window state
[task 2021-07-10T01:14:52.199Z] 01:14:52     INFO - TEST-START | browser/components/downloads/test/browser/browser_downloads_panel_ctrl_click.js
Summary: Intermittent [tier 2] browser/components/downloads/test/browser/browser_downloads_panel_context_menu.js | Cleanup function threw an exception - UnknownError: Unexpected error: NS_ERROR_FAILURE → Intermittent browser/components/downloads/test/browser/browser_downloads_panel_context_menu.js | Cleanup function threw an exception - UnknownError: Unexpected error: NS_ERROR_FAILURE

There have been a total of 86 failures in the last 7 days on the following platforms:

  • windows10-64-2004-qr opt
  • windows10-64-2004-shippable-qr opt

Recent failure log

[task 2021-08-27T11:46:32.947Z] 11:46:32     INFO - Leaving test bound Canceled PDF download
[task 2021-08-27T11:46:32.948Z] 11:46:32     INFO - removing C:\Users\task_163006379216279\AppData\Local\Temp\dm-ui-test.file
[task 2021-08-27T11:46:32.948Z] 11:46:32     INFO - Buffered messages finished
[task 2021-08-27T11:46:32.949Z] 11:46:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/downloads/test/browser/browser_downloads_panel_context_menu.js | Cleanup function threw an exception - UnknownError: Unexpected error: NS_ERROR_FAILURE
[task 2021-08-27T11:46:32.950Z] 11:46:32     INFO - GECKO(504) | MEMORY STAT | vsize 2104319MB | vsizeMaxContiguous 66776527MB | residentFast 363MB | heapAllocated 175MB
[task 2021-08-27T11:46:32.950Z] 11:46:32     INFO - TEST-OK | browser/components/downloads/test/browser/browser_downloads_panel_context_menu.js | took 201ms```
Whiteboard: [stockwell needswork:owner]
Assignee: nobody → apavel
Status: NEW → ASSIGNED

Hi Marco, can you please take a look or assign someone to?
Thank you!

Assignee: apavel → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(mak)

"Cleanup function threw an exception - UnknownError: Unexpected error: NS_ERROR_FAILURE"

the only cleanup functions here are basically using IOUtils, considering there is a "removing..." log message, we are probably here:
https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/browser/components/downloads/test/browser/head.js#44-49

I wonder if this is an unexpected Windows fs condition that causes the error to happen, this code was changed from OS.File in Bug 1711053, I wonder if Ava would have a chance to look at it, in the worst case we could try to figure out which of the calls is throwing and why, or catch it if we figure out it's something that may effectively happen. In general tests creating files should try to use randomized names so that even if we fail to cleanup up after them (that we should still try to) next test runs won't have problems. I think that is the case here because gTestTargetFile is unique, so even catching removal problems should not be a big deal.

Depends on: 1711053
Flags: needinfo?(mak) → needinfo?(ava8katushka)
Assignee: nobody → apavel
Status: NEW → ASSIGNED
Assignee: apavel → nobody
Status: ASSIGNED → NEW
Pushed by ctuns@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ce279cc979b
disable browser_downloads_panel_context_menu.js on win10 not debug r=intermittent-reviewers,jmaher DONTBUILD
Assignee: nobody → apavel
Status: NEW → ASSIGNED
Keywords: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Assignee: apavel → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.