1720171 - Specific site fails to load with Enhanced Tracking Protection (likely due to Analytics shim)

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screen Shot 2021-07-12 at 13.15.50.png

There are a couple of pages on the Hamilton Public Library website that do not render correctly with ETP enabled. The pages require logging in, I can provide my credentials to developers who need to test (also I can test patches).

When the page loads, it flashes some content and then immediately is replaced by an error page. The web console shows a JS error about window.ga.getAll().filter not being found, where I'm assuming ga is the shimmed Google Analytics thing. Screenshot attached.

This is on macOS, Firefox nightly 2021-07-10. I've also seen it on Fenix, it's been happening for a while.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Looks like the real GA code returns an Array for window.ga.getAll() while the FF shim returns an Iterator. Should be easy enough to fix.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I used mozregression to confirm this is a regression from bug 1713687, which changed ga.getAll() from returning an empty hard-coded Array to returning an Iterator (tracker.values()). I kicked off a try push to test a fix.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Verified try push resolves the problem.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1720171 - Ensure ga.getAll().filter exists in SmartBlock Google Analytics shim. r?twisniewski

The original GA code returns an Array for ga.getAll(), while the
shim was returning an Iterator. This caused code that relied on
ga.getAll().filter(..) to break with the shim. This patch wraps
the Iterator contents back into an Array.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77aebc0081f7
Ensure ga.getAll().filter exists in SmartBlock Google Analytics shim. r=twisniewski,webcompat-reviewers

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/77aebc0081f7

Comment 7

[Pascal Chevrel:pascalc]

Kartikaya, is that a common enough issue that we should uplift the fix to beta 91? Thanks

Comment 8

[Kartikaya Gupta (email:[e-mail])]

I don't really know how common it is, but the website where I encountered it is using a template shared by other sites too. Given that the fix seems low-risk I would lean towards uplifting.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 9230927 [details]
Bug 1720171 - Ensure ga.getAll().filter exists in SmartBlock Google Analytics shim. r?twisniewski

Beta/Release Uplift Approval Request

• User impact if declined: Some websites may not function properly
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Seems pretty low risk
• String changes made/needed: none

Comment 10

[Pascal Chevrel:pascalc]

Kartikaya, this patch does not graft cleanly to beta as we have version 24.0.0 of the webcompat intervention addon while this patch is on top of bug 1713701 which shipped a version 24.1.0, should we also uplift bug 1713701?

Comment 11

[Kartikaya Gupta (email:[e-mail])]

I'll defer that question to :twisniewski as I'm not familiar with development process in this area.

Comment 12

[Thomas Wisniewski [:twisniewski]]

@Pascal, you may uplift both if you'd like, or you can simply change the version number in this patch to the next one up for beta. (The patches should otherwise not conflict, IIRC).

Comment 13

[Pascal Chevrel:pascalc]

Comment on attachment 9230927 [details]
Bug 1720171 - Ensure ga.getAll().filter exists in SmartBlock Google Analytics shim. r?twisniewski

Thanks, let's uplift this one in beta 5 and also take bug 1713701

Comment 14

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/f0e3ce76aad8

Comment 15

[Simona Badau, Desktop QA]

Tried to verify the fix on Firefox 92 beta 7 but I do not have the credentials for the Hamilton Public Library website.

Kartikaya, when time permits, could you please confirm the issue is fixed?

Thanks!

Comment 16

[Kartikaya Gupta (email:[e-mail])]

I verified this is fixed on the latest beta. Thanks!