1720300 - Remove browser.proton.enabled Telemetry probe

Status: RESOLVED FIXED

(Firefox :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=345074371&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/K5r909_NR_qZNuDiiR5fog/runs/0/artifacts/public/logs/live_backing.log

---

============================= test session starts ==============================
[task 2021-07-13T12:11:31.808Z]  0:05.57 platform linux -- Python 3.6.9, pytest-3.6.2, py-1.10.0, pluggy-0.6.0 -- /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/python-test/bin/python
[task 2021-07-13T12:11:31.808Z]  0:05.57 rootdir: /builds/worker/checkouts/gecko, inifile: /builds/worker/checkouts/gecko/config/mozunit/mozunit/pytest.ini
[task 2021-07-13T12:11:31.809Z]  0:05.57 collecting ... collected 1 item
[task 2021-07-13T12:11:31.809Z]  0:05.57 
[task 2021-07-13T12:11:31.809Z]  0:05.57 toolkit/components/glean/pytest/test_no_expired_metrics.py::test_no_metrics_expired TEST-UNEXPECTED-FAIL
[task 2021-07-13T12:11:31.809Z]  0:05.57 
[task 2021-07-13T12:11:31.809Z]  0:05.57 =================================== FAILURES ===================================
[task 2021-07-13T12:11:31.809Z]  0:05.57 ___________________________ test_no_metrics_expired ____________________________
[task 2021-07-13T12:11:31.809Z]  0:05.57 
[task 2021-07-13T12:11:31.809Z]  0:05.57     def test_no_metrics_expired():
[task 2021-07-13T12:11:31.809Z]  0:05.57         """
[task 2021-07-13T12:11:31.809Z]  0:05.57         Of all the metrics included in this build, are any expired?
[task 2021-07-13T12:11:31.809Z]  0:05.57         If so, they must be removed or renewed.
[task 2021-07-13T12:11:31.809Z]  0:05.58 
[task 2021-07-13T12:11:31.809Z]  0:05.58         (This also checks other lints, as a treat.)
[task 2021-07-13T12:11:31.809Z]  0:05.58         """
[task 2021-07-13T12:11:31.809Z]  0:05.58         with open("browser/config/version.txt", "r") as version_file:
[task 2021-07-13T12:11:31.809Z]  0:05.58             app_version = version_file.read().strip()
[task 2021-07-13T12:11:31.809Z]  0:05.58 
[task 2021-07-13T12:11:31.809Z]  0:05.58         options = run_glean_parser.get_parser_options(app_version)
[task 2021-07-13T12:11:31.809Z]  0:05.58         metrics_paths = [Path(x) for x in metrics_yamls]
[task 2021-07-13T12:11:31.809Z]  0:05.58         all_objs = parser.parse_objects(metrics_paths, options)
[task 2021-07-13T12:11:31.809Z]  0:05.58         assert not util.report_validation_errors(all_objs)
[task 2021-07-13T12:11:31.809Z]  0:05.58 >       assert not lint.lint_metrics(all_objs.value, options)
[task 2021-07-13T12:11:31.809Z]  0:05.58 E       AssertionError: assert not [<glean_parser.lint.GlinterNit object at 0x7f1e3cdf40b8>]
[task 2021-07-13T12:11:31.809Z]  0:05.58 E        +  where [<glean_parser.lint.GlinterNit object at 0x7f1e3cdf40b8>] = <function lint_metrics at 0x7f1e3d183d08>(OrderedDict([('fog', OrderedDict([('initialization', <glean_parser.metrics.Timespan object at 0x7f1e3ed947b8>), ('fail...8358>)])), ('browser.ui', OrderedDict([('proton_enabled', <glean_parser.metrics.Boolean object at 0x7f1e3cdffac8>)]))]), {'allow_reserved': False, 'custom_is_expired': <function get_parser_options.<locals>.<lambda> at 0x7f1e3cd85950>, 'custom_validate_expires': <function get_parser_options.<locals>.<lambda> at 0x7f1e3cd859d8>})
[task 2021-07-13T12:11:31.809Z]  0:05.58 E        +    where <function lint_metrics at 0x7f1e3d183d08> = lint.lint_metrics
[task 2021-07-13T12:11:31.809Z]  0:05.58 E        +    and   OrderedDict([('fog', OrderedDict([('initialization', <glean_parser.metrics.Timespan object at 0x7f1e3ed947b8>), ('fail...8358>)])), ('browser.ui', OrderedDict([('proton_enabled', <glean_parser.metrics.Boolean object at 0x7f1e3cdffac8>)]))]) = <glean_parser.util.keep_value.<locals>.ValueKeepingGenerator object at 0x7f1e3cd707b8>.value
[task 2021-07-13T12:11:31.809Z]  0:05.58 
[task 2021-07-13T12:11:31.809Z]  0:05.58 toolkit/components/glean/pytest/test_no_expired_metrics.py:39: AssertionError
[task 2021-07-13T12:11:31.810Z]  0:05.58 =========================== 1 failed in 0.23 seconds ===========================
[task 2021-07-13T12:11:31.810Z]  0:05.58 Sorry, Glean found some glinter nits:
[task 2021-07-13T12:11:31.810Z]  0:05.58 WARNING: EXPIRED: browser.ui.proton_enabled: Metric has expired. Please consider removing it.

[task 2021-07-13T12:11:31.810Z]  0:05.58 Please fix the above nits to continue.
[task 2021-07-13T12:11:31.810Z]  0:05.58 To disable a check, add a `no_lint` parameter with a list of check names to disable.
[task 2021-07-13T12:11:31.810Z]  0:05.58 This parameter can appear with each individual metric, or at the top-level to affect the entire file.
[task 2021-07-13T12:11:31.810Z]  0:05.58 Setting retcode to 1 from /builds/worker/checkouts/gecko/toolkit/components/glean/pytest/test_no_expired_metrics.py
[task 2021-07-13T12:11:31.813Z]  0:05.58 Return code from mach python-test: 1
[task 2021-07-13T12:11:31.839Z] Test configuration changed. Regenerating backend.
[task 2021-07-13T12:11:31.839Z] No build detected, test metadata may be incomplete.
[taskcluster 2021-07-13 12:11:33.047Z] === Task Finished ===
[taskcluster 2021-07-13 12:11:33.047Z] Unsuccessful task run with exit code: 1 completed in 520.699 seconds

Comment 1

[Chris H-C :chutten]

Recomponenting to match bug 1715129

Comment 2

[Sandor Molnar[:smolnar]]

Did some backfills and it seems it started with this merge

Comment 3

[Chris H-C :chutten]

:smolnar, this would be due to the version increasing causing the mentioned metric browser.ui.proton_enabled to be expired.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1720300 - Remove browser.proton.enabled preference probe. r?Gijs!

Comment 5

[Intermittent Failures Robot]

57 failures in 470 pushes (0.121 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 14
• autoland: 43

Platform and build breakdown:

• linux1804-64: 51
  • opt: 51
• windows10-64: 3
  • opt: 3
• macosx1014-64: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1720300&startday=2021-07-13&endday=2021-07-13&tree=all

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b9f82dcd8f6
Remove browser.proton.enabled preference probe. r=Gijs

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3b9f82dcd8f6

Comment 8

[Intermittent Failures Robot]

74 failures in 2224 pushes (0.033 failures/push) were associated with this bug in the last 7 days.

This is the #9 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 20
• autoland: 54

Platform and build breakdown:

• linux1804-64: 58
  • opt: 58
• windows10-64: 4
  • opt: 4
• macosx1014-64: 12
  • opt: 12

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1720300&startday=2021-07-12&endday=2021-07-18&tree=all