Closed Bug 1720335 Opened 4 years ago Closed 3 years ago

Add setup abstraction that interacts correctly with `.only` and `.skip`

Categories

(Testing :: Mochitest, defect, P3)

Product:
Testing
Component:
Mochitest
Version:
Default
Platform:
Desktop
All
Type:
defect

Tracking

(firefox98 fixed)

Status:
RESOLVED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
firefox98 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1720335 - add add_setup helper that adds setup methods, r?standard8
48 bytes, text/x-phabricator-request
Details | Review

Although we have registerCleanupFunction, we do not have an equivalent for test setup.

Right now .only() doesn't always work right, because it doesn't take into account setup tasks as, well, required setup.

If we had appropriate setup functions, this would work right.

We could automatically transform the thousand+ "setup" functions that are in the tree already using eslint.

Severity: -- → S3
Priority: -- → P3
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Blocks: 1753696
Summary: Add setup abstraction that interacts correctly with `.only` and `.skip`, and use lint rule to transform existing setup methods → Add setup abstraction that interacts correctly with `.only` and `.skip`

https://hg.mozilla.org/mozilla-central/rev/9257ed6922d7

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox98: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
Regressions: 1753963
Blocks: 1755159
Blocks: 1757040
Depends on: 1938971
See Also: → 1957513
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: