1720354 - Visual issues with `button-menu-button` element

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: Peek 2021-07-13 10-34.gif

I spotted some visual issues in the attachment reminder notification button-menu-button.

• The hover effect is slightly delayed between the button and the menulist button.
• When the menulist is opened, the active background color bleeds out underneath the main button at the edges, probably due to a different border radius.
• The menulist is missing the background color.

I'm not sure if these issues affect other implementations of this custom element, but the toolbarbutton don't seem to be affected.

I'm setting P1/S1 not for the visual style but for the missing background of the menulist, which makes it almost impossible to read.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1720354 - Set a color on the #reminderBarPopup and fix the "bleeding" on the menu-button. r=aleca

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/53b56a0c1e37
Set a color on the #reminderBarPopup and fix the "bleeding" on the menu-button. r=aleca

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9231048 [details]
Bug 1720354 - Set a color on the #reminderBarPopup and fix the "bleeding" on the menu-button. r=aleca

[Approval Request Comment]
User impact if declined: incorrect highlighting of the notification bar buttons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9231048 [details]
Bug 1720354 - Set a color on the #reminderBarPopup and fix the "bleeding" on the menu-button. r=aleca

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 91.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/8f3454eb5a6d

Comment 6

[Magnus Melin [:mkmelin]]

More work expected in this bug?

Comment 7

[Richard Marti (:Paenglab)]

The different hover timing of the button and dropmarker isn't fixed.

Comment 8

[Thomas D. (:thomas8)]

(In reply to Richard Marti (:Paenglab) from comment #7)

The different hover timing of the button and dropmarker isn't fixed.

I've carried the tiny remainder over to bug 1782790 to get this off the radar.
Let's avoid keeping bugs open for a minor remaining issue especially when the main problem was P2/S2 and above and has been fixed.
Fwiw, the visual glitch which was fixed here is far from S1 (catastrophic), see the severity legend.