1720369 - Switch to Tab option appears in Private window for non-Private Tab Using Search Shortcut

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Haik Aftandilian [:haik]]

Attachment: Screenshot showing the "Switch to Tab" button displaying in a private browsing window

I have 'p' setup as a searchfox.org path search shortcut. In a private browsing window, when I start typing p <previously used search> the "switch to tab" option appears even though the tab to switch to is in a non-private window. Choosing the "switch to tab" has no effect.

Comment 1

[Marco Bonardo [:mak]]

Maybe a regression from bug 1686951? Daisuke, what do you think?

Comment 2

[Daisuke Akatsuka (:daisuke)]

Yeah, I think so. Please let me check.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: no-swtich-to-tab.png

Hello Haik, thank you very much!

May I ask your env and STRs since I could not reproduce this issue with the following STRs??

1. open https://searchfox.org/mozilla-central/source/netwerk/protocol/res/ExtensionProtocolHandler.cpp in non-private window
2. open a private window
3. type "ex" in addressbar in the private window
   As the attachment, I could not see "switch to tab".

And also, I tried two types of search shortcuts.
First, ominbox, https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/omnibox
Second, search shortcut addon (I made it using https://addons.mozilla.org/ja/firefox/addon/add-custom-search-engine/)
I tried both search shortcuts, but could not reproduce it yet.

So, I'd like to know your STRs and how to make your search shortcut.
Thanks!

Comment 4

[Haik Aftandilian [:haik]]

I can reliably reproduce the problem with a new profile, but the steps include restarting the browser and don't require using a search shortcut. See video here. (Video is hosted on dropbox.com. Login should not be required. Dismiss the login dialog by clicking 'X' if necessary.)

The steps followed are

1. Open Nightly with a new profile
2. Visit searchfox.org
3. Do a path search for ExtensionProtocolHandler.cpp (for example)
4. Observe ExtensionProtocolHandler.cpp is displayed
5. Quit Nightly
6. Re-open Nightly
7. Type "exte" in the search bar and then choose ExtensionProtocolHandler.cpp from the list of suggestions.
8. Open a new private window
9. Type "ex" in the search bar
10. The "Switch to Tab" problem occurs

Comment 5

[Daisuke Akatsuka (:daisuke)]

Thank you very much for the detailed information!
Yes, I could reproduce it with your STRs.
I will take a look at this issue.

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1720369: Avoid showing adaptive history of different private-browsing mode as switch-to-tab.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d15d56adc84
Avoid showing adaptive history of different private-browsing mode as switch-to-tab. r=adw

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9d15d56adc84

Comment 9

[Drew Willcoxon :adw]

Comment on attachment 9233903 [details]
Bug 1720369: Avoid showing adaptive history of different private-browsing mode as switch-to-tab.

Beta/Release Uplift Approval Request

• User impact if declined: Nominating this for a 91 dot release since it's privacy related. This bug is new on 91 and fixed on 92. It causes private and non-private switch-to-tab results to be commingled. i.e., tabs from private windows can be visible in non-private windows and vice versa, as switch-to-tab results in the address bar panel.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 4
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small change that changes one value, and it has a test
• String changes made/needed:

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Nominating this for 91 ESR since it's privacy related. This bug is new on 91 and fixed on 92.
• User impact if declined: It causes private and non-private switch-to-tab results to be commingled. i.e., tabs from private windows can be visible in non-private windows and vice versa, as switch-to-tab results in the address bar panel.
• Fix Landed on Version: 92
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small change that changes one value, and it has a test
• String or UUID changes made by this patch:

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 92.0a1 (2021-07-13) on Windows 10x64 and STR from comment 4.
The issue is verified fixed with Firefox 93.0a1 (20210815094823) and 92.0b4 (20210815185614) on Windows 10x64, macOS 10.13 and Ubuntu 21.04. Switch to tab option is no longer displayed inside Private Window after following STR from comment 4.

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9233903 [details]
Bug 1720369: Avoid showing adaptive history of different private-browsing mode as switch-to-tab.

new regression, simple fix, verified in nightly and beta; approved for 91.0.1, thanks

Comment 12

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/59023012b29a

Comment 13

[Julien Cristau [:jcristau]]

for 91.0.1esr (FIREFOX_91_0_X_RELBRANCH):
https://hg.mozilla.org/releases/mozilla-esr91/rev/da45987611e7bd2758ea4c6a4c422d5863e8b7fa

for 91.1esr (default):
https://hg.mozilla.org/releases/mozilla-esr91/rev/5d8c2777952b40620cd0b4c2f251f1f39799f08d

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Added to the 91.0.1 relnotes:

Fixed an issue which caused tabs from private windows to be visible in non-private windows when viewing switch-to-tab results in the address bar panel

Comment 15

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with 91.0.1 (20210816143654) and 91.0.1esr (20210816144842) on Windows 10x64, macOS 10.15 and Ubuntu 21.04. The Switch to tab option is no longer displayed in the private window after following steps from comment 4.

Comment 16

[Adrian Florinescu [:aflorinescu]]

In terms of qa coverage, I don't think having a specific test for the specific scenario that causes this regression would be the proper action item here, so - for that. However, we are lacking in terms of coverage involving interaction betwen normal and private mode, area that QA intends to add coverage in the future.