1720386 - UVC version regex for Thunderbird next-version update testing

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Rob Lemley [:rjl]]

For Thunderbird update-verify-next jobs, a new regex is needed in update_verify_config.py:INCLUDE_VERSION_REGEXES.

Thunderbird release versions do not have an "esr" suffix even though the repository is named comm-esrXX. This means that the "esr91-next" regex would not match. (UVC uses the "nonbeta" regex which also does not work.)

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1720386 - Add a regex for Thunderbird update-verify-next version matching. r?#taskgraph-reviewers

The update-verify-next test is new in Thunderbird 91. Since Thunderbird versions
do not include the esr suffix, a separate regex is needed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6c9bfa1591c
Add a regex for Thunderbird update-verify-next version matching. r=taskgraph-reviewers,bhearsum

Comment 3

[Atila Butkovits]

Backed out for causing linting failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/cfd04147e8932a0b4daa939aaaa66ac7c548e513

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=W290qWoiTZOmPlauQrrF2w.0&revision=f6c9bfa1591c918a7c688f7d95436d118d16b587&searchStr=linting%2Copt%2Cpython%2Cchecks%2Csource-test-mozlint-py-black%2Cblack

Failure log: https://treeherder.mozilla.org/logviewer?job_id=345204248&repo=autoland&lineNumber=118

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ec7dd0cc7ac
Add a regex for Thunderbird update-verify-next version matching. r=taskgraph-reviewers,bhearsum

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7ec7dd0cc7ac

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9231164 [details]
Bug 1720386 - Add a regex for Thunderbird update-verify-next version matching. r?#taskgraph-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: No user impact, this affects UpdateVerify tests only
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds an additional regex for version detection that will be used by Thunderbird 91 to run the update-verify-next set of tests. Should have no impact on Firefox as the regex is used only when selected.
• String changes made/needed: no

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9231164 [details]
Bug 1720386 - Add a regex for Thunderbird update-verify-next version matching. r?#taskgraph-reviewers

Approved for 91 beta 5, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/c27c4e451c97