1726216 - Invalid INCLUDE_VERSION_REGEX for thunderbird91-next in update_verify_config.py

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Rob Lemley [:rjl]]

The regex for thunderbird91-next is missing a closing single quote. When its passed to the shell to generate the cfg file, it fails as a result. The issue went unnoticed until the release of Thunderbird 91.0.1.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1726216 - Fix thunderbird91-next regex in update_verify_config.py. r?#taskgraph-reviewers

The missing closing single quote causes update-verify-config-next to fail as
the value is used in a shell commandline.
Added a quick test to look for this kind of error since apparently it is easy
to miss.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1720386

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98afbe520452
Fix thunderbird91-next regex in update_verify_config.py. r=taskgraph-reviewers,jmaher

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/98afbe520452

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rjl, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9236717 [details]
Bug 1726216 - Fix thunderbird91-next regex in update_verify_config.py. r?#taskgraph-reviewers

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is for Update-Verify-Next tests for Thunderbird esr91 builds. Currently those tests do not run due to the missing single quote at the end of the regex.
• User impact if declined: No user impact, just more manual testing for Thunderbird release drivers and testers. If possible, I would like to get this included in 91.1.0.
• Fix Landed on Version: 93
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fixes an error with the regex that was added in bug 1720386. Without the final single-quote, the shell command fails, so no update-verify config file is created, and no update-verify-next tests run. The only affected jobs would be Update Verify Config Next for Thunderbird, that sets "extras:include-version" to "thunderbird91-next". No impact to Firefox is expected.
• String or UUID changes made by this patch: N/A

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9236717 [details]
Bug 1726216 - Fix thunderbird91-next regex in update_verify_config.py. r?#taskgraph-reviewers

Approved for 91.1esr.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/71156356c682