1720547 - Outgoing username field is not disabled when "No Authentication" is selected from the outgoingAuthMethod

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Alessandro Castellani [:aleca]]

We dropped the IDs for those select options so we should rely on the selectedIndex as we won't change it.

Comment 1

[Ben Bucksch (:BenB)]

Why not re-add the IDs for this purpose? That should be more reliable and readable than the index.

Comment 2

[Alessandro Castellani [:aleca]]

(In reply to Ben Bucksch (:BenB) from comment #1)

Why not re-add the IDs for this purpose? That should be more reliable and readable than the index.

Yeah, that sounds good to me.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: Bug 1720547 - Disable outgoing username field if 'No Authentication' is selected in outgoingAuthMethod. r=rjl,BenB

Comment 4

[Alessandro Castellani [:aleca]]

Used the occasion to add a test covering this scenario.

Comment 5

[Ben Bucksch (:BenB)]

Patch looks good to me. Just a small change suggested.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b996db48beaa
Disable outgoing username field if 'No Authentication' is selected in outgoingAuthMethod. r=rjl,BenB

Comment 7

[José M. Muñoz]

TEST-UNEXPECTED-FAIL | comm/mail/test/browser/account/browser_mailAccountSetupWizard.js | Uncaught exception - Timeout waiting for the outgoing username field to be disabled - timed out after 50 tries.

Comment 8

[Alessandro Castellani [:aleca]]

The test passes locally, as usual.
Based on the screenshot (https://firefoxci.taskcluster-artifacts.net/d4FIfitwQU2-cfLNnPl7xA/0/public/test_info/mozilla-test-fail-screenshot_fwgrfylb.png), this seems to be once again related to the fact that the item in which we try to simulate the click is not inside the visible viewport.
I'll take care of this in a tiny follow up patch.

Comment 9

[Alessandro Castellani [:aleca]]

Attachment: Bug 1720547 - Follow up: Fix outgoing auth select broken test. rs=bustage-fix

Comment 10

[Alessandro Castellani [:aleca]]

try-run: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=df2866989a1146c39e7891f241d108968b4a447a

Comment 11

[Geoff Lankow (:darktrojan)]

Calling this checkin-needed even though it's still WIP in Phab.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8f740fa48cd8
Follow up: Fix outgoing auth select broken test. r=darktrojan

Comment 13

[Rob Lemley [:rjl]]

Comment on attachment 9231240 [details]
Bug 1720547 - Disable outgoing username field if 'No Authentication' is selected in outgoingAuthMethod. r=rjl,BenB

[Approval Request Comment]
Regression caused by (bug #): 5df88be32508
User impact if declined: Username field is still active when it should not be
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
UI bug. Confusing to the user to have the username field active unexpectedly.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9231240 [details]
Bug 1720547 - Disable outgoing username field if 'No Authentication' is selected in outgoingAuthMethod. r=rjl,BenB

[Triage Comment]
Approved for beta

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 91.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/5a56df456d91
https://hg.mozilla.org/releases/comm-beta/rev/813ca4c61978