1720619 - Add instantiation-specific subset of CompileOptions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

As a preparation for bug 1720331, we can add a accessor class for CompileOptions& for instantiation functions, so that the set of required fields become clearer.

Comment 1

[Tooru Fujisawa [:arai]]

it turns out that only 3 bool fields are used during instantiation, after bug 1719402.
We can just add JS::InstantiateOptions with those fields.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1720619 - Part 1: Make instantiation parameters more specific. r?tcampbell!

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1720619 - Part 2: Add JS::InstantiateOptions. r?tcampbell!

Depends on D120200

Comment 4

[Tooru Fujisawa [:arai]]

we need to apply this also to decode case

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:arai, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Tooru Fujisawa [:arai]]

This is going to be landed in the next cycle

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee26b692fa60
Part 1: Make instantiation parameters more specific. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/a9b5bd39f725
Part 2: Add JS::InstantiateOptions. r=tcampbell

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ee26b692fa60
https://hg.mozilla.org/mozilla-central/rev/a9b5bd39f725