Closed Bug 1720619 Opened 1 year ago Closed 1 year ago

Add instantiation-specific subset of CompileOptions

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(2 files)

As a preparation for bug 1720331, we can add a accessor class for CompileOptions& for instantiation functions, so that the set of required fields become clearer.

it turns out that only 3 bool fields are used during instantiation, after bug 1719402.
We can just add JS::InstantiateOptions with those fields.

Summary: Add instantiation-specific accessor for CompileOptions → Add instantiation-specific subset of CompileOptions

we need to apply this also to decode case

Blocks: 1726498

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:arai, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(tcampbell)
Flags: needinfo?(arai.unmht)

This is going to be landed in the next cycle

Flags: needinfo?(tcampbell)
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/ee26b692fa60
Part 1: Make instantiation parameters more specific. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/a9b5bd39f725
Part 2: Add JS::InstantiateOptions. r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.