1720692 - Crash in [@ mozilla::dom::ScriptLoadRequestList::AppendElement]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

4 crashes from 4 different installations.

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/eff0b013-0218-4afb-9aca-ca22c0210713

Reason: EXCEPTION_BREAKPOINT

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::ScriptLoadRequestList::AppendElement dom/script/ScriptLoadRequest.h:368
1 xul.dll mozilla::dom::ScriptElement::MaybeProcessScript dom/script/ScriptElement.cpp:119
2 xul.dll mozilla::dom::HTMLScriptElement::BindToTree dom/html/HTMLScriptElement.cpp:52
3 xul.dll nsINode::ReplaceOrInsertBefore dom/base/nsINode.cpp:2712
4 xul.dll mozilla::dom::Node_Binding::insertBefore dom/bindings/NodeBinding.cpp:929
5 xul.dll mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3297
6 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:511
7 xul.dll Interpret js/src/vm/Interpreter.cpp:3226
8 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:543
9 xul.dll js::jit::InvokeFromInterpreterStub js/src/jit/VMFunctions.cpp:784

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1720692 - Remove all preload requests from the off-thread compiling requests list when the preload request is used r?dpalmeiro

When a preload request is used, it might be being compiled off-thread.
Currently this is handled for defer and async requests in AddDeferRequest and
AddAsyncRequest but not for XSLT or other kinds of requests. The patch handles
this whenever we use a preload request.

I don't know for sure that this is what's causing the crash but it seems likely
given the assertion.

Depends on D120072

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbb89c5b851b
Remove all preload requests from the off-thread compiling requests list when the preload request is used r=dpalmeiro

Comment 3

[Atila Butkovits]

Backed out for causing bustages complaining about 'CommandContext'.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b158fd312491d673aa1438c222f1f66fa3b61c89

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=IRYZdG3STOK0PhwFK-UBBQ.0&revision=fbb89c5b851b9af53297389699bc53b14456bdd0&searchStr=os%2Cx%2Ccross%2Ccompiled%2Cdebug%2Cc%2Fc%2B%2B%2Cchecks%2Csource-test-clang-macosx64-non-unified%2Cnon-unified

Failure log: https://treeherder.mozilla.org/logviewer?job_id=345457502&repo=autoland&lineNumber=558
https://treeherder.mozilla.org/logviewer?job_id=345457500&repo=autoland&lineNumber=754

Comment 4

[Atila Butkovits]

Relanding. It was a wrongful backout

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/765b2ecc3cb9
Remove all preload requests from the off-thread compiling requests list when the preload request is used r=dpalmeiro

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/765b2ecc3cb9