1720862 - CalDAV setup prompts for password but doesn't send it

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Martin Giger [:freaktechnik]]

When trying to set up my nextcloud calDAV calendar I get prompted to enter a password (which by the way is already saved for cardDAV). However the subsequent propfind sends an empty password (Authorization: Basic base64(username:)) instead of the value I entered in the password prompt. When that fails with a 401, the code falls back to user less discovery and ultimately fails.

This is possibly a dupe of bug 1688448.

Comment 1

[Geoff Lankow (:darktrojan)]

I know why this is. I'm about to fix it along with a related problem that doesn't appear to have a bug yet, so I'll do both here.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1720862 - When detecting calendars, use a new user context for each request. r=freaktechnik,john.bieling

Detection probes servers in two stages, firstly without authenticating, then if necessary asking for the password and trying again.
If the server responds with HTTP 401 in the first stage, we've been incorrectly trying to authenticate with the username and no password, then in the second stage using that same authentication (cached by network code) and failing.
This patch prevents the attempt to auth when there's no password, and separates all requests in detection sessions to avoid the caching problem.

Comment 3

[Geoff Lankow (:darktrojan)]

Setting checkin-needed as I'm finished for the week. It'd still be helpful if you double-checked this worked, Martin.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3a4eab1e7350
When detecting calendars, use a new user context for each request. r=freaktechnik,john.bieling

Comment 5

[John Bieling (:TbSync)]

Comment on attachment 9232763 [details]
Bug 1720862 - When detecting calendars, use a new user context for each request. r=freaktechnik,john.bieling

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Certain CalDAV calendars cannot be setup.

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9232763 [details]
Bug 1720862 - When detecting calendars, use a new user context for each request. r=freaktechnik,john.bieling

[Triage Comment]
Approved for beta

Not a regression?

Comment 7

[Martin Giger [:freaktechnik]]

Compared to ESR it is a regression, sure. As in the calendar prompting my initial report worked fine there.

Comment 8

[Geoff Lankow (:darktrojan)]

We'll blame Paul. He's not here to defend himself.

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 91.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/24821244330c