1720879 - Option to open "Add Security Exception" window never offered after failing connection to self-signed IRC server

Status: VERIFIED FIXED

(SeaMonkey :: Chat, defect)

Description

[Job Bautista]

Attachment: Screenshot_2021-07-16_20-51-13.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.8

Steps to reproduce:

Try connecting to an IRC server with a self-signed certificate. You can use irc.blackaster.xyz port 6697 or 9999 as a testcase.

Actual results:

Connection fails as expected, but the option to add an exception is never offered. It consistently returns the following:

Connection to ircs://irc.blackaster.xyz/ (ircs://irc.blackaster.xyz/) closed with status 2153398258. Reconnecting in 15 seconds.

Expected results:

Connection failing, and offer to add an exception. Like this:

ircs://irc.blackaster.xyz/ has an invalid security certificate. If you trust this server, [add an exception].

Comment 1

[Job Bautista]

Weirdly, I'm able to add an exception in rdmsoft's 0.9.92. So might be a regression introduced in .93 or .94?

Comment 2

[Ian Neal]

Some of the underlying network code was changed and the fix is to cherry pick the following commits from the ambassador fork:
https://github.com/Ascrod/ambassador/commit/ab5e5261bdd7faeeb2ddddae8029182c62e99e18
https://github.com/Ascrod/ambassador/commit/d1bdcbb9eca71bfff936aa4e5ed7dab4f1be0866

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/091eec35b1c5
Option to open "Add Security Exception" window never offered after failing connection to self-signed IRC server. r=IanN

Comment 4

[Job Bautista]

CTCP version string: ChatZilla 0.10b1pre [SeaMonkey 2.53.10/20211012210003]

Can verify in latest nightly build of WG9s' 2.53.10b1pre (20211012210003) that this bug has been resolved. I can proceed to the "Add Security Exception" window as expected.

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/d8a7c1d4e37f49053276b2123537635e1dd40686
Option to open "Add Security Exception" window never offered after failing connection to self-signed IRC server. r=IanN a=IanN

Comment 6

[Frank-Rainer Grahl (:frg)]

Attachment: 1720879-irc-network-error-handling-25310.patch

Looks like the patch was reviewed outside of bugzilla by IanN. r/a+ carried forward.