Chatzilla highlights urls in chat but clicking them doesn't bring browser window to the front

RESOLVED FIXED

Status

RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: david, Assigned: rginda)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1) Gecko/20020826
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1) Gecko/20020826

If you are chatting with chatzilla and someone posts a link, clicking it will
cause it to display in a browser window, but if there is one browser window open
and it is popped down, it doesn't pop up after clicking on the link in chatzilla
(though the browser does display the contents of the url when you manually pop
it up).  This is un-intuitive.

Reproducible: Always

Steps to Reproduce:
covered under details


Expected Results:  
It should have popped up the browser window so it comes to the foreground.

Updated

16 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Hardware: PC → All

Comment 1

16 years ago
This works for me on Linux.  Is this Windows only?

Comment 2

16 years ago
Now with a recent build, it's not working any more.

Comment 3

16 years ago
The need for this to be fixed should go away when bug 106542 is fixed.
Depends on: 106542

Comment 4

15 years ago
So much for that bug dependancy...

I guess something is needed around
http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/content/commands.js#1492.
Product: Core → Other Applications

Comment 5

14 years ago
Created attachment 168970 [details] [diff] [review]
patch v1. gives focus to browser

Sets focus to the browser when opening links in something other than a new
window. Also fixes the bug that makes links open twice when opening them from
cz in a tab, in the same tab. (There was code to open it in a new window, but
no return, so it also opened in the same tab after all)

Updated

14 years ago
Attachment #168970 - Flags: review?(silver)

Comment 6

14 years ago
Comment on attachment 168970 [details] [diff] [review]
patch v1. gives focus to browser

Style nit: the blank line should not have those 4 spaces.

r=silver with that change.
Attachment #168970 - Flags: review?(silver) → review+

Comment 7

14 years ago
Checked in --> FIXED.

This bug fix will be available in the next planned release of ChatZilla, 0.9.67.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Comment 8

14 years ago
We need a preference for this feature.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 9

14 years ago
(In reply to comment #8)
> We need a preference for this feature.

Taking, again. Unless someone feels like doing it within about 5 hours (I need
to finish other stuff first). Shouldn't be too hard to fix. I do have one
question though. Without this patch, we noticed this behaviour:

- Opening a link in an existing window - was not focused
- Opening a link in a new window - was focused

Should the latter be affected by the pref, thus opening the window in the
background while keeping chatzilla focused? (If possible)

Comment 10

14 years ago
(In reply to comment #8)
> We need a preference for this feature.

Most definitely. I want .66e back, but us poor OS/2 users don't get nightlies
nightly. So, even if this got fixed today, I might not see it for a month. :-(

Comment 11

14 years ago
I've already got a patch, just fighting Firefox to test it...

I'm not sure we can do /that/ much with the new window problem, that's kinda out
of our control. (we could re-focus ourselves when the other window is open, but
how would we know when that has opened and stolen our focus?)

Comment 12

14 years ago
How is it handled in mailnews? 

Comment 13

14 years ago
Created attachment 169444 [details] [diff] [review]
Adds a preference for window.focus() call
Attachment #168970 - Attachment is obsolete: true
Attachment #169444 - Flags: review?(samuel)

Updated

14 years ago
Attachment #169444 - Flags: review?(samuel) → review+

Comment 14

14 years ago
Checked in --> FIXED (again).

I'll be doing a 0.9.67-pre2 with this in shortly.
Status: REOPENED → RESOLVED
Last Resolved: 14 years ago14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.