172094 - Chatzilla highlights urls in chat but clicking them doesn't bring browser window to the front

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[David Campbell]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1) Gecko/20020826
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1) Gecko/20020826

If you are chatting with chatzilla and someone posts a link, clicking it will
cause it to display in a browser window, but if there is one browser window open
and it is popped down, it doesn't pop up after clicking on the link in chatzilla
(though the browser does display the contents of the url when you manually pop
it up).  This is un-intuitive.

Reproducible: Always

Steps to Reproduce:
covered under details


Expected Results:  
It should have popped up the browser window so it comes to the foreground.

Comment 1

[Samuel Sieb]

This works for me on Linux.  Is this Windows only?

Comment 2

[Samuel Sieb]

Now with a recent build, it's not working any more.

Comment 3

[Samuel Sieb]

The need for this to be fixed should go away when bug 106542 is fixed.

Comment 4

[James Ross]

So much for that bug dependancy...

I guess something is needed around
http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/content/commands.js#1492.

Comment 5

[:Gijs (he/him)]

Attachment: patch v1. gives focus to browser

Sets focus to the browser when opening links in something other than a new
window. Also fixes the bug that makes links open twice when opening them from
cz in a tab, in the same tab. (There was code to open it in a new window, but
no return, so it also opened in the same tab after all)

Comment 6

[James Ross]

Comment on attachment 168970 [details] [diff] [review]
patch v1. gives focus to browser

Style nit: the blank line should not have those 4 spaces.

r=silver with that change.

Comment 7

[James Ross]

Checked in --> FIXED.

This bug fix will be available in the next planned release of ChatZilla, 0.9.67.

Comment 8

[James Ross]

We need a preference for this feature.

Comment 9

[:Gijs (he/him)]

(In reply to comment #8)
> We need a preference for this feature.

Taking, again. Unless someone feels like doing it within about 5 hours (I need
to finish other stuff first). Shouldn't be too hard to fix. I do have one
question though. Without this patch, we noticed this behaviour:

- Opening a link in an existing window - was not focused
- Opening a link in a new window - was focused

Should the latter be affected by the pref, thus opening the window in the
background while keeping chatzilla focused? (If possible)

Comment 10

[Felix Miata]

(In reply to comment #8)
> We need a preference for this feature.

Most definitely. I want .66e back, but us poor OS/2 users don't get nightlies
nightly. So, even if this got fixed today, I might not see it for a month. :-(

Comment 11

[James Ross]

I've already got a patch, just fighting Firefox to test it...

I'm not sure we can do /that/ much with the new window problem, that's kinda out
of our control. (we could re-focus ourselves when the other window is open, but
how would we know when that has opened and stolen our focus?)

Comment 12

[Felix Miata]

How is it handled in mailnews? 

Comment 13

[James Ross]

Attachment: Adds a preference for window.focus() call

Comment 14

[James Ross]

Checked in --> FIXED (again).

I'll be doing a 0.9.67-pre2 with this in shortly.