1720947 - NewMailNotification is not seeing new mails sometimes.

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[John Bieling (:TbSync)]

While working on bug 1716051, I found this:

https://searchfox.org/comm-central/rev/c2dae586a341861ce8b97e8de35e5444f747aad0/mailnews/base/src/MailNotificationManager.jsm#210-213

    let folders = changedFolder.descendants;
    if (folders.length == 0) {
      folders = [changedFolder];
    }

This causes changedFolder itself to be ignored, if it has descendants. The effect is, that if I get a OnItemIntPropertyChanged notification for the BiffState or NewMailReceived property for my actual INBOX folder (which happen to have subfolders) -> I get no new mail notification.

I do not know what defines which folder is triggering this (sometimes the root folder, sometimes the INBOX folder), but in the second case, I get no notifications.

For the WebExt API I use

    let folders = changedFolder.descendants;
    folders.unshift(changedFolder);

Should we fix that here as well?

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1720947 - Fix new mail notification. r=mkmelin

Comment 2

[Wayne Mery (:wsmwk)]

(If this doesn't affect v78 please change fields)

Comment 3

[John Bieling (:TbSync)]

The file "MailNotificationManager.jsm" does not exist in TB78, so a fix for TB91/92 cannot be backported, so lets make this just about TB91/Tb92.

Comment 4

[John Bieling (:TbSync)]

I guess the triage owner has to confirm this, before I can send the patch for review?

Comment 5

[Ping Chen [:rnons] (away)]

The patch looks good to me. Problem only happens when Inbox has sub-folders, right?

Comment 6

[John Bieling (:TbSync)]

Yes, and never on first received mail, but on second or third. I have not understood, why sometimes the root folder is triggering the event, and sometimes the inbox folder. If it is the inbox folder, no notification.

Comment 7

[Ping Chen [:rnons] (away)]

The backend code is https://searchfox.org/comm-central/rev/564bad8f71edcd07e7f2493d4317e752f78de9a9/mailnews/base/src/nsMsgDBFolder.cpp#4135-4136

When the biff state of a folder changes, the event is emitted from the root folder. For the second/third new messages, biff state doesn't change, so the event is from the real folder itself. I don't know why it's designed like this though.

Comment 8

[John Bieling (:TbSync)]

Perfect, that completely explains the behavior I see and everybody should be able to reproduce this bug.

Comment 9

[Magnus Melin [:mkmelin]]

(In reply to John Bieling (:TbSync) from comment #4)

I guess the triage owner has to confirm this, before I can send the patch for review?

You can always submit a patch independent of the bug status.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5529ef349700
Fix new mail notification. r=mkmelin

Comment 11

[Uplift Request]

Time for uplift requests?

Comment 12

[John Bieling (:TbSync)]

Comment on attachment 9231655 [details]
Bug 1720947 - Fix new mail notification. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Missing email notifications in some edge cases.

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
None.

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9231655 [details]
Bug 1720947 - Fix new mail notification. r=mkmelin

[Triage Comment]
Approved for beta

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 92.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/559f17846501

Comment 15

[John Bieling (:TbSync)]

Comment on attachment 9231655 [details]
Bug 1720947 - Fix new mail notification. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Missing email notifications in some edge cases.

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
None.

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9231655 [details]
Bug 1720947 - Fix new mail notification. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 91.2.0:
https://hg.mozilla.org/releases/comm-esr91/rev/f5cb78b9a907