1720950 - [OpenPGP] user-unfriendly options when offering to import .asc key attachments

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Gus Andrews]

Attachment: Screen Shot 2021-07-13 at 12.16.33 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

May be the same as bug 1704820

Mac Big Sur 11.4, Daily 92.0a1 (2021-07-13) (64-bit)
I send my account an unencrypted email from my Gmail account, with a .asc public key attached
I send my account an unencrypted email from another account, with the same .asc public key attached
I double-click each email to open them
I expand the "attachments" footer in each email

Actual results:

When I right-click on the attachment in one email, it gives me the “Import OpenPGP Key” option. When I right-click on the attachment in the other email, the "Import OpenPGP Key" option cannot be selected and only the "Decrypt and open" and "Decrypt and save as" options are available. (See attached.) It is not clear what causes the difference between those options; trying these steps again I got the result that neither attachment gave me the "import" option, only the "decrypt" options.

Expected results:

Any key attachment should give the user the "Import OpenPGP Key" option on right click. It is possible that should even be the option on click; right-click seems like extra effort and hiding the option from the user.

"Decrypt and save as" will save keys somewhere else on the user's device, where they may lose track of the keys and might struggle to get them imported to OpenPGP's key manager to use them.

Comment 1

[Gus Andrews]

Attachment: Screen Shot 2021-07-13 at 12.10.10 PM.png

Comment 2

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/dc30a5c99706435363248e97bca67b782aa01070/mail/base/content/msgHdrView.js#2274 -> https://searchfox.org/comm-central/rev/dc30a5c99706435363248e97bca67b782aa01070/mail/extensions/openpgp/content/ui/enigmailMsgHdrViewOverlay.js#704 -> https://searchfox.org/comm-central/rev/dc30a5c99706435363248e97bca67b782aa01070/mail/extensions/openpgp/content/ui/enigmailMsgHdrViewOverlay.js#744-749

But I couldn't reproduce the problem.
Decrypt and save is only related to encrypted attachments, and should only be shown then. Since this is a context menu it should be contextual and not show at all when not relevant.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1720950 - hide irrelevant context menu items related to OpenPGP and attachments. r=PatrickBrunschwig

I noticed errors weren't shown properly for decryp failure, since the Fluent file was not included in messenger.xhtml

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b0275aea861b
hide irrelevant context menu items related to OpenPGP and attachments. r=PatrickBrunschwig

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9235985 [details]
Bug 1720950 - hide irrelevant context menu items related to OpenPGP and attachments. r=PatrickBrunschwig

[Approval Request Comment]
Regression caused by (bug #): not a regression
User impact if declined: Confusing UX: OpenPGP related attachments menus disabled instead of hidden. But importantly also fixes the missing string include which means in error situations a blank dialog was shown (we never got any report about it though)
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): Not risky.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9235985 [details]
Bug 1720950 - hide irrelevant context menu items related to OpenPGP and attachments. r=PatrickBrunschwig

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 92.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/f8a91a69e242

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9235985 [details]
Bug 1720950 - hide irrelevant context menu items related to OpenPGP and attachments. r=PatrickBrunschwig

[Triage Comment]
Approved for esr91

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 91.0.2:
https://hg.mozilla.org/releases/comm-esr91/rev/5cf549d5f7b7