1720951 - Remove remaining "ensure_bytes()" and "ensure_unicode()" usages

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task)

Description

[Mitchell Hentges [:mhentges] 🦀]

We have a bunch of ensure_bytes() and ensure_unicode() usages that can be simplified to either:

• Always just use the value directly
• Always convert the value to bytes/str

This will simplify each instance from bytes|str to either always bytes or always str.

Comment 1

[Surajeet Das]

Attachment: Bug 1720951 - Removed instances of 'ensure_bytes()' from js/src/builtin r=mhentges

Removed dependency of 'ensure_bytes()' from mozbuild/util.py and did inline the usage of 'ensure_bytes()' .

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58a418d302fa
Removed instances of 'ensure_bytes()' from js/src/builtin r=mhentges

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/58a418d302fa

Comment 4

[Surajeet Das]

Attachment: Bug 1720951 - Removed instances of 'ensure_bytes()' from python/mozbuild/mozbuild r=mhentges

Inlined the usage of 'ensure_bytes()' and removed dependency of 'ensure_bytes()' from util.py .

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/919c542f5b8b
Removed instances of 'ensure_bytes()' from python/mozbuild/mozbuild r=mhentges

Comment 6

[Surajeet Das]

Attachment: Bug 1720951 - Removed instances of 'ensure_bytes()' and 'ensure_unicode()' from mozbuild/mozpack r=mhentges

Inlined the usages of 'ensure_bytes()' and 'ensure_unicode()' .

Comment 7

[Surajeet Das]

Attachment: Bug 1720951 - Removed instances of 'ensure_bytes()' from xpcom/ds/tools r=mhentges

Inlined the usage of 'ensure_bytes()' .

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 919c542f5b8b (Bug 1720951) for causing build bustages and py3 failures in test_jarmaker.py.
https://hg.mozilla.org/integration/autoland/rev/dc485cda7210d332a3fdae02577adb9b64b9a39d

Bustage:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=919c542f5b8b88cb476e4886b0860bdfc8aa445e&selectedTaskRun=Pvgz_vYITs-_DT6BnPk8gA.0
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=345761026&repo=autoland&lineNumber=74448

py3 failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=919c542f5b8b88cb476e4886b0860bdfc8aa445e&selectedTaskRun=dtGdKAOUSH-thog3HBZDrQ.0
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=345760999&repo=autoland&lineNumber=1126

Comment 9

[Surajeet Das]

Attachment: Bug 1720951 - Removed unused 'ensure_bytes()' and 'ensure_unicode()' from runxpcshelltests.py r=mhentges

Since the functions 'ensure_bytes()' and 'ensure_unicode()' were unused, hence removed.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22fcf5699b7c
Removed unused 'ensure_bytes()' and 'ensure_unicode()' from runxpcshelltests.py r=mhentges

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/22fcf5699b7c

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 13

[Mathew Hodson]

I think this bug should be closed since a bunch of patches were landed by Surajeet Das. A new bug can be created for any remaining work.

Comment 14

[Mitchell Hentges [:mhentges] 🦀]

The majority of the ensure_...() functions were handled, so that's a good call. Thanks Mathew.