Closed Bug 1721088 Opened 1 year ago Closed 1 year ago

Make the toolbarbutton/menulist menus more Big Sur like

Categories

(Thunderbird :: Theme, task)

Tracking

(thunderbird91? fixed)

RESOLVED FIXED
92 Branch
Tracking Status
thunderbird91 ? fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(3 files, 1 obsolete file)

The toolbarbutton/menulist menus do not look like the Big Sur native menuitems.

Attached patch 1721088-Big-Sur-menu-look.patch (obsolete) — Splinter Review

This makes the toolbarbutton/menulist menus more Big Sur like.

Additionally I found that the arrow-right.svg was a 12px version. I changed it to 16px. On some places I changed the arrows to arrow-right-12.svg to look correct.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9231771 - Flags: review?(alessandro)
Comment on attachment 9231771 [details] [diff] [review]
1721088-Big-Sur-menu-look.patch

Review of attachment 9231771 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good as it makes those menulists look more native on macOS.
A tiny issue from this is that at first glance those menus look pretty big compared to what we currently have, but I guess it's the BigSur style.
I have no way of testing this but are we sure these changes won't affect previous versions of macOS?
Attachment #9231771 - Flags: review?(alessandro) → review+

Rob, could you check on 10.15 if the button/menulist menuitems (for example the Tag button menu) have the same height as the main menu menuitems?
Try https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=e24f332366bbf392a88f89fbeaa7a33f18b5fbbe

A screenshot of both would be appreciated. :-)

Attached image image.png
Attached image image.png
Target Milestone: --- → 92 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/848b59436e3f
[Mac] Make the toolbarbutton/menulist menus more Big Sur like. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/b923f2280bbc
follow-up - Fix CSS syntax error. rs=bustage-fix

Patch with the bustage fix.

[Approval Request Comment]
User impact if declined: Not so good integration into macOS 11
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9231771 - Attachment is obsolete: true
Attachment #9232415 - Flags: review+
Attachment #9232415 - Flags: approval-comm-beta?

Comment on attachment 9232415 [details] [diff] [review]
1721088-Big-Sur-menu-look.patch

[Triage Comment]
Approved for beta

Attachment #9232415 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.