1721088 - Make the toolbarbutton/menulist menus more Big Sur like

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

The toolbarbutton/menulist menus do not look like the Big Sur native menuitems.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1721088-Big-Sur-menu-look.patch

This makes the toolbarbutton/menulist menus more Big Sur like.

Additionally I found that the arrow-right.svg was a 12px version. I changed it to 16px. On some places I changed the arrows to arrow-right-12.svg to look correct.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9231771 [details] [diff] [review]
1721088-Big-Sur-menu-look.patch

Review of attachment 9231771 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good as it makes those menulists look more native on macOS.
A tiny issue from this is that at first glance those menus look pretty big compared to what we currently have, but I guess it's the BigSur style.
I have no way of testing this but are we sure these changes won't affect previous versions of macOS?

Comment 3

[Richard Marti (:Paenglab)]

Rob, could you check on 10.15 if the button/menulist menuitems (for example the Tag button menu) have the same height as the main menu menuitems?
Try https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=e24f332366bbf392a88f89fbeaa7a33f18b5fbbe

A screenshot of both would be appreciated. :-)

Comment 4

[Rob Lemley [:rjl]]

Attachment: image.png

Comment 5

[Rob Lemley [:rjl]]

Attachment: image.png

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/848b59436e3f
[Mac] Make the toolbarbutton/menulist menus more Big Sur like. r=aleca

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b923f2280bbc
follow-up - Fix CSS syntax error. rs=bustage-fix

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1721088-Big-Sur-menu-look.patch

Patch with the bustage fix.

[Approval Request Comment]
User impact if declined: Not so good integration into macOS 11
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9232415 [details] [diff] [review]
1721088-Big-Sur-menu-look.patch

[Triage Comment]
Approved for beta

Comment 10

[Dave Miller [:justdave]]

Thunderbird 910b3:
https://hg.mozilla.org/releases/comm-beta/rev/ec25799f6980
https://hg.mozilla.org/releases/comm-beta/rev/1d478f343b2f