1721173 - Hardcoded text colors don’t play well with high-contrast themes

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Valentin Villenave]

Attachment: HighContrast.png

Open e.g. the Account Settings tab using a high-contrast theme.

Some text labels (e.g. menu items) are hardcoded as #fff, and thus
are barely readable when highlighted in a dark theme.

Even worse, some text labels (for example on the Account Actions
dropdown button), hardcoded as #000, become totally invisible
when on a black background. Seriously, it took me a couple of
minutes (and the help of my bloody screen reader!) to understand
where that damned button had gone.

This is a regression (see #1348573, marked as fixed, or much older bugs
such as #469300); pre-photon the user theme was all but ignored
and replaced with a pseudo-Adwaita or AdwaitaDark theme.

Comment 1

[Valentin Villenave]

Attachment: HighContrastInverse.png

(I should mention that all this is with version 92.0a1, build 20210719095626)

Comment 2

[Valentin Villenave]

Attachment: Adwaita.png

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1721173-accountActionsButton.patch

We need to more synchronize this button/popups after the Proton changes.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9232088 [details] [diff] [review]
1721173-accountActionsButton.patch

Review of attachment 9232088 [details] [diff] [review]:
-----------------------------------------------------------------

Good fixes, thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d0b4683f5089
Use the in-content colors for the accountActionsButton. r=aleca

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9232088 [details] [diff] [review]
1721173-accountActionsButton.patch

[Approval Request Comment]
User impact if declined: not so good theme integration in Account manager
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9232088 [details] [diff] [review]
1721173-accountActionsButton.patch

[Triage Comment]
Approved for beta

Comment 8

[Dave Miller [:justdave]]

Thunderbird 910b3:
https://hg.mozilla.org/releases/comm-beta/rev/7b255da42c41