1721306 - [Fission BFCache] Hover text does not disappear when navigating to a different page

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Justin Peter]

Attachment: about:support

Honestly no idea what component to put this in, sorry.

When hovering over an <img> with the title attribute set, a popup with this text will appear. Normally this text disappears when the mouse is no longer hovering over the image, but this does not happen if the page is navigated away from.

Steps to reproduce:

1. Navigate to m.xkcd.com (or another page with an image and title text)
2. Hover over the image
3. Press ctrl+L and navigate to a different page (Note: for the STR to work, the address bar suggestions must not cover the mouse; using a taller image or pasting an address may help here).
4. The hover text does not go away

Things that make the text go away:

• Switching tabs

Things that do not make the text go away:

• Reloading the tab
• Moving the mouse outside of the window
• Minimizing the window

Occurs on the latest nightly, please ask if you have any questions or there's anything I can do to help.

Comment 1

[Justin Peter]

Attachment: Video demonstrating the issue

Comment 2

[Alice0775 White]

I can reproduce the issue if Fission is enabled.

Comment 3

[Alice0775 White]

Regression window:
https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=windows%2C2012%2Cx64%2Copt&tochange=7d32671931b7&fromchange=ab936b7f0c9f9e0b27e42e3f7909131bface08b9

Comment 4

[Alice0775 White]

Regression window(with fission.bfcacheInParent and fission.autostart is enabled):
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dc3c1fd56cb806c7e63f07ef04433c1f3c46f303&tochange=d683ade21debe1d108e7ad85d62e9087d67cefe3

Comment 5

[Chris Peterson [:cpeterson]]

Alice, thanks for finding the regression range!

DOM Navigation code is responsible for hiding the tooltip. LocationChange events are being sent to the old content process.

Tracking for Fission MVP.

Comment 6

[Chris Peterson [:cpeterson]]

This bug is a hard blocker for Fission M8.

Comment 7

[Chris Peterson [:cpeterson]]

Olli, I'm tentatively assigning this Fission M8 bug to you because it appears to be a regression from bfcacheInParent.

Comment 8

[Olli Pettay [:smaug]]

FWIW, this is an old issue. One can trigger this even without Fission by killing a child process when the tooltip is shown.
Obviously Fission with bfcache makes this happen more easily.

Comment 9

[Olli Pettay [:smaug]]

Attachment: Bug 1721306, hide the tooltip when deactivating a BrowserParent, r=peterv

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37008f131c6f
hide the tooltip when deactivating a BrowserParent, r=peterv

Comment 11

[Marian-Vasile Laza]

Backed out changeset 37008f131c6f (Bug 1721306) for causing bustages on SessionHistoryEntry.cpp.
Backout link
Push with failures
Failure Log

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cb9f52db17e
hide the tooltip when deactivating a BrowserParent, r=peterv

Comment 13

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/2cb9f52db17e

Comment 14

[Justin Peter]

I can confirm that this is now fixed.