BFCache in parent, skeleton
Categories
(Core :: DOM: Navigation, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
(Whiteboard: fission-bfcache)
Attachments
(17 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
The name RemotenessChangeState uses same the convention as the related methods, even though there might
not be a remoteness change happening, only a browsing context switch. But the naming
inconsistency exists there even without any bfcache work.
Depends on D105228
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D105229
Assignee | ||
Comment 5•3 years ago
|
||
Depends on D105230
Assignee | ||
Comment 6•3 years ago
|
||
Depends on D105231
Assignee | ||
Comment 7•3 years ago
|
||
Depends on D105232
Assignee | ||
Comment 8•3 years ago
|
||
Depends on D105233
Assignee | ||
Comment 9•3 years ago
|
||
EvictOutOfRangeContentViewers call in SetFrameLoader doesn't do anything in this patch, but will
work with some followups.
Depends on D105234
Assignee | ||
Comment 10•3 years ago
|
||
Depends on D105235
Assignee | ||
Comment 11•3 years ago
|
||
There are quite a few different logging modules for session history, but while developing
SHIP BFCache, I'd prefer to add some specific one for it. Later we can perhaps
merge various modules to some generic session history related.
SHIPBFCache log module will be used more in the followup patches.
Depends on D105236
Assignee | ||
Comment 12•3 years ago
|
||
Depends on D105237
Assignee | ||
Comment 13•3 years ago
|
||
Depends on D105238
Assignee | ||
Comment 14•3 years ago
|
||
Non-SHIP bfcache seems to be rather complicated here, since it needs to explicitly store inner windows and what not.
SHIP should be able to handle this in a simpler way.
It is possible that some ordering needs still tweaking.
Depends on D105239
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 15•3 years ago
|
||
This addresses part of the review comment from https://phabricator.services.mozilla.com/D105229
Depends on D105360
Assignee | ||
Comment 16•3 years ago
|
||
Depends on D106561
Assignee | ||
Comment 17•3 years ago
•
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b36b53bda469f07ad465a2992a0629fd1ad1f5cd
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b2424c505b668b49567936af391cbe6125b1826
https://treeherder.mozilla.org/#/jobs?repo=try&revision=323661ae21185521a37390a071e97df0c98c45ae
https://treeherder.mozilla.org/#/jobs?repo=try&revision=062d84788f3b325c795d8e7cb04e570912b3f856
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ddc26f0a6ad86a78b33791854a6a4c9040047f82
https://treeherder.mozilla.org/#/jobs?repo=try&revision=70e3f8a6b6aa5907977a494525a59c508ad1c5c6
Assignee | ||
Comment 19•3 years ago
|
||
Depends on D106562
Comment 20•3 years ago
|
||
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6d02e59ddc51 set active entry only when session history runs in the parent process, r=peterv https://hg.mozilla.org/integration/autoland/rev/63295b3a62d0 pass various states of remoteness change / browsing context swap using a helper struct, r=peterv https://hg.mozilla.org/integration/autoland/rev/6138bfc6c08d add a comment about missing LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL, r=peterv https://hg.mozilla.org/integration/autoland/rev/7e8022e5696a Add DocumentChannel ID to DocumentLoadListener, r=peterv https://hg.mozilla.org/integration/autoland/rev/c261c243a64d add a pref to enable bfcache in parent process, r=peterv https://hg.mozilla.org/integration/autoland/rev/278db692aa8b remove an assertion in SessionStorageManager.cpp since it isn't valid anymore with bfcache, r=peterv,ttung https://hg.mozilla.org/integration/autoland/rev/701eccb34772 add assertions to ensure SessionHistoryEntry objects are created only when session history in parent is enabled, r=peterv https://hg.mozilla.org/integration/autoland/rev/04aadec67ce2 store nsFrameLoader in SessionHistoryEntry/SHEntrySharedParentState, r=peterv https://hg.mozilla.org/integration/autoland/rev/307bde43cc96 make it possible to call Document::CanSavePresentation non-recursively, r=peterv https://hg.mozilla.org/integration/autoland/rev/2b2081a15d67 add a log module for SHIP BFCache, r=peterv https://hg.mozilla.org/integration/autoland/rev/334aeb627855 try to use bfcache for top level pages, r=peterv https://hg.mozilla.org/integration/autoland/rev/2fca23521891 evict frameloaders from bfcache (missing still the time based eviction), r=peterv https://hg.mozilla.org/integration/autoland/rev/0c5fe977ced6 nested freeze/thaw, r=peterv https://hg.mozilla.org/integration/autoland/rev/a594bd02b8b6 Rename RemotenessChangeState to RemotenessChangeOptions, r=peterv https://hg.mozilla.org/integration/autoland/rev/745eaa468c74 hide fission.bfcacheInParent pref access behind a function which checks that also SHIP is enabled, r=peterv,necko-reviewers https://hg.mozilla.org/integration/autoland/rev/6e5523a7210d sync fields when loading a page from bfcache, r=peterv
Comment 21•3 years ago
|
||
Backout by malexandru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46614681fd5d Backed out 16 changesets for causing cpp bustages in nsFrameLoader.
Comment 22•3 years ago
•
|
||
Backed out 16 changesets (Bug 1689601) for causing cpp bustages in nsFrameLoader.
Backout link: https://hg.mozilla.org/integration/autoland/rev/46614681fd5d96fc75ef2c7033abe96d402dcba4
Push with failures, failure log.
Comment 24•3 years ago
|
||
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/094c4ba34fd1 set active entry only when session history runs in the parent process, r=peterv https://hg.mozilla.org/integration/autoland/rev/1502dc96c13f pass various states of remoteness change / browsing context swap using a helper struct, r=peterv https://hg.mozilla.org/integration/autoland/rev/c1ff2ca96a32 add a comment about missing LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL, r=peterv https://hg.mozilla.org/integration/autoland/rev/0f5fe8762bd6 Add DocumentChannel ID to DocumentLoadListener, r=peterv https://hg.mozilla.org/integration/autoland/rev/46bcd4860216 add a pref to enable bfcache in parent process, r=peterv https://hg.mozilla.org/integration/autoland/rev/07595dc11e77 remove an assertion in SessionStorageManager.cpp since it isn't valid anymore with bfcache, r=peterv,ttung https://hg.mozilla.org/integration/autoland/rev/e74a62e11d2d add assertions to ensure SessionHistoryEntry objects are created only when session history in parent is enabled, r=peterv https://hg.mozilla.org/integration/autoland/rev/53d514bab3e8 store nsFrameLoader in SessionHistoryEntry/SHEntrySharedParentState, r=peterv https://hg.mozilla.org/integration/autoland/rev/42d89fdeef20 make it possible to call Document::CanSavePresentation non-recursively, r=peterv https://hg.mozilla.org/integration/autoland/rev/b32ce9ca1137 add a log module for SHIP BFCache, r=peterv https://hg.mozilla.org/integration/autoland/rev/37793ca0cd36 try to use bfcache for top level pages, r=peterv https://hg.mozilla.org/integration/autoland/rev/20f2436c594c evict frameloaders from bfcache (missing still the time based eviction), r=peterv https://hg.mozilla.org/integration/autoland/rev/fc52b96ee244 nested freeze/thaw, r=peterv https://hg.mozilla.org/integration/autoland/rev/0b82d215b4ea Rename RemotenessChangeState to RemotenessChangeOptions, r=peterv https://hg.mozilla.org/integration/autoland/rev/6ed03eb5b7fb hide fission.bfcacheInParent pref access behind a function which checks that also SHIP is enabled, r=peterv,necko-reviewers https://hg.mozilla.org/integration/autoland/rev/d683ade21deb sync fields when loading a page from bfcache, r=peterv
Comment 25•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/094c4ba34fd1
https://hg.mozilla.org/mozilla-central/rev/1502dc96c13f
https://hg.mozilla.org/mozilla-central/rev/c1ff2ca96a32
https://hg.mozilla.org/mozilla-central/rev/0f5fe8762bd6
https://hg.mozilla.org/mozilla-central/rev/46bcd4860216
https://hg.mozilla.org/mozilla-central/rev/07595dc11e77
https://hg.mozilla.org/mozilla-central/rev/e74a62e11d2d
https://hg.mozilla.org/mozilla-central/rev/53d514bab3e8
https://hg.mozilla.org/mozilla-central/rev/42d89fdeef20
https://hg.mozilla.org/mozilla-central/rev/b32ce9ca1137
https://hg.mozilla.org/mozilla-central/rev/37793ca0cd36
https://hg.mozilla.org/mozilla-central/rev/20f2436c594c
https://hg.mozilla.org/mozilla-central/rev/fc52b96ee244
https://hg.mozilla.org/mozilla-central/rev/0b82d215b4ea
https://hg.mozilla.org/mozilla-central/rev/6ed03eb5b7fb
https://hg.mozilla.org/mozilla-central/rev/d683ade21deb
Description
•