1721372 - browser_styleeditor_inline_friendly_names.js fails with server side target switching enabled

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Description

[Alexandre Poirot [:ochameau]]

$ ./mach mochitest --headless devtools/client/styleeditor/test/browser_styleeditor_inline_friendly_names.js --setpref devtools.target-switching.server.enabled=true

This is mostly because previous target is being destroyed after the new one initializes itself.

More concretely here, with this test, styleSheetChangeEventsEnabled is being set to false by previous target page style actor:
https://searchfox.org/mozilla-central/rev/79a3ae0b0fa6abeca2cb7cf220df293c8dec9207/devtools/server/actors/style-sheets.js#74
after the new target (of the page we navigate to) set this same attribute to true:
https://searchfox.org/mozilla-central/rev/79a3ae0b0fa6abeca2cb7cf220df293c8dec9207/devtools/server/actors/utils/stylesheets-manager.js#144

This ends up disable notifications of new stylesheet, which is why this test doesn't see new stylesheets on navigations. The platform code won't fire StyleSheetApplicableStateChanged because of that.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1721372 - [devtools] Fix styleeditor tests helper when reloading a page with a target switch.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1721372 - [devtools] Fix browser_styleeditor_inline_friendly_names.js with server side targets.

Destroy previous target before instantiating a new one.
Otherwise we will destroy it after having setup the new one
and the teardown sequence of the previous may undo the setup of the second.

Typically, in styleeditor, the styleSheetChangeEventsEnabled boolean would be toggled
to true by the new target and reset back to false by the old target.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b23689338b30
[devtools] Fix styleeditor tests helper when reloading a page with a target switch. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/2730382d175b
[devtools] Fix browser_styleeditor_inline_friendly_names.js with server side targets. r=nchevobbe

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b23689338b30
https://hg.mozilla.org/mozilla-central/rev/2730382d175b