1721398 - browser_jsterm_autocomplete_getters_cache.js fails with server side target switching enabled

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Alexandre Poirot [:ochameau]]

$ ./mach mochitest --headless devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_cache.js --setpref devtools.target-switching.server.enabled=true

This one test fail because the browsing context target actor tries to restore the focus during a target switch, which uterly confuses this test which times out over here:
https://searchfox.org/mozilla-central/rev/79a3ae0b0fa6abeca2cb7cf220df293c8dec9207/devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_cache.js#123
We end up trigerring a key shortcut, while the console is no longer focused, instead the web page is.
The page is focused because of this code:
https://searchfox.org/mozilla-central/rev/79a3ae0b0fa6abeca2cb7cf220df293c8dec9207/devtools/server/actors/targets/browsing-context.js#1318
Which unconditionaly tries to restore the focus to the page anytime the target is destroyed. Ideally this should only be done when we close the toolbox and it really shouldn't be done during a target switch.

See bug 1721379, where we are having similar issues, but rather about creation instead of destruction.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1721398 - [devtools] Fix browser_jsterm_autocomplete_getters_cache.js

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1721398 - [devtools] Don't restore target configuration on target switching. r=ochameau.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1c0b1655e1b
[devtools] Don't restore target configuration on target switching. r=ochameau.

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a1c0b1655e1b