1721454 - Second "Manage bookmarks" item is not at bottom of Bookmarks Menu after landing patch from bug #1720534

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

First and second "Manage bookmarks" items in Bookmarks Menu are separated only by 2 items, which are "Bookmarks toolbar" and "Other bookmarks".

The regression is caused by:

Bug 1720534 - Clean up styles in Bookmarks Menu Button menupopups on Windows 7 and 10. r=desktop-theme-reviewers,dao

This also gets rid of a dead CSS class (panel-subview-footer).

Differential Revision: https://phabricator.services.mozilla.com/D119906

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug 1721454 - bad.png

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug 1721454 - good.png

Comment 4

[Adrian Florinescu [:aflorinescu]]

This issue also affects Mac and although I haven't checked, mostly likely linux as well. Although the regressing issue component is themes, I'm moving to Bookmarks and History, since IMO, it belongs there.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1721454 - Insert bookmarks before bottom Manage Bookmarks in Bookmarks Menu button. r?NeilDeakin!

The CSS class panel-subview-footer-button was removed from the BMB_bookmarksShowAll
element in the Bookmarks Menu toolbar button, but this class is used by browser-places.js
to know where to insert the user's bookmarks in the structure of the menu.

Since this is the only menu that attachPlacesView attaches to, we can supply
the ID of the bottom Manage Bookmarks element, which will cause browserPlacesView.js
to insert the user's bookmarks above it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccf38b42b39b
Insert bookmarks before bottom Manage Bookmarks in Bookmarks Menu button. r=NeilDeakin

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ccf38b42b39b